Replace Riot by Element #4121
Merged
Replace Riot by Element #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcornelissen
added
the
breaking change
github-actions
bot
added
the
new icon
ericcornelissen
added
update icon/data
|
I'm seeing some differences between your optimization and the original, also comparing it with my version: My optimizationM5.593 14.218c-.485 0-.88-.392-.88-.877 0-3.282 2.668-5.943 5.958-5.943.486 0 .88.393.88.877s-.394.877-.88.877c-2.318 0-4.198 1.877-4.198 4.19 0 .486-.393.878-.88.878zm8.615 4.19c0 .485-.394.878-.88.878-3.29 0-5.956-2.662-5.956-5.945 0-.483.394-.876.88-.876.484 0 .878.393.878.877 0 2.316 1.88 4.192 4.2 4.192.484 0 .878.392.878.877zm4.2-8.626c.484 0 .878.392.878.877 0 3.282-2.667 5.943-5.957 5.943-.486 0-.88-.393-.88-.877s.394-.877.88-.877c2.318 0 4.198-1.877 4.198-4.19 0-.486.393-.878.88-.878zm-8.602-4.19c0-.485.394-.878.88-.878 3.29 0 5.956 2.662 5.956 5.945 0 .483-.394.876-.88.876-.485 0-.878-.393-.878-.877 0-2.316-1.88-4.192-4.2-4.192-.484 0-.878-.392-.878-.877zM12 24c6.627 0 12-5.373 12-12S18.627 0 12 0 0 5.373 0 12s5.373 12 12 12zDifferences between your version (red) and original unoptimized (original color)
Differences between your version (red) and mine optimized (black)
|
This comment has been minimized.
This comment has been minimized.
|
Thanks for the review guys, guess I was a little too quick with submitting this one. I re-added the icon, now with an optimized precision of 4 |
service-paradis
approved these changes
Nov 23, 2020
Merged
github-actions bot
added a commit
that referenced
this pull request
Nov 29, 2020
…ved icon (v4.0.0) # New Icons - GitHub Sponsors (#3730) # Updated Icons - AppSignal (#3873) - Atlassian (#3872) - Atom (#3884) - Audio-Technica (#3885) - Bitbucket (#3887) - Bower (#3888) - C (#3868) - C++ (#3869) # Renamed Icons - _Adobe Lightroom CC_ to _Adobe Lightroom_ (#4120) - _Google Hangouts Chat_ to _Google Chat_ (#4141) - _Google Hangouts Meet_ to _Google Meet_ (#4141) - _Groovy_ to _Apache Groovy_ (#4120) - _Postwoman_ to _Hoppscotch_ (#4122) - _Riot_ to _Element_ (#4121) - _Tor_ to _Tor Project_ (#3442) # Removed Icons - Mixer (#4119)
ericcornelissen
added a commit
that referenced
this pull request
Nov 29, 2020
…ved icon (v4.0.0) - GitHub Sponsors (#3730) - AppSignal (#3873) - Atlassian (#3872) - Atom (#3884) - Audio-Technica (#3885) - Bitbucket (#3887) - Bower (#3888) - C (#3868) - C++ (#3869) - _Adobe Lightroom CC_ to _Adobe Lightroom_ (#4120) - _Google Hangouts Chat_ to _Google Chat_ (#4141) - _Google Hangouts Meet_ to _Google Meet_ (#4141) - _Groovy_ to _Apache Groovy_ (#4120) - _Postwoman_ to _Hoppscotch_ (#4122) - _Riot_ to _Element_ (#4121) - _Tor_ to _Tor Project_ (#3442) - Mixer (#4119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Closes #3606, removes Riot and replaces it by Element in preparation for the upcoming v4 release.
The new SVG is based on the SVG found in the header of the Element homepage. The color is taken from that SVG. Optimized using the SVGO CLI at a precision of
34.