Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tencent Weibo #4222

Merged
merged 4 commits into from May 24, 2021
Merged

Remove Tencent Weibo #4222

merged 4 commits into from May 24, 2021

Conversation

fbernhart
Copy link
Contributor

@fbernhart fbernhart commented Dec 2, 2020

Issue: #3169
Alexa rank: -

Checklist

- [ ] I updated the JSON data in _data/simple-icons.json --> (wasn't necessary)
- [x] I optimized the icon with SVGO or SVGOMG
- [x] The SVG viewbox is 0 0 24 24

Description

I took the already used SVG.
I used Inkscape to fix size and center
I used https://jakearchibald.github.io/svgomg/ to optimize the resulting SVG

Edit

This PR removes the Tencent Weibo icon from Simple Icons as the brand no longer exists. See the discussion below for details.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Dec 2, 2020
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Wikipedia, Tencent Weibo was scheduled to be shutdown in September 2020. Should this be marked for deletion in v5.0.0 @simple-icons/maintainers?

@adamrusted adamrusted added the in discussion There is an ongoing discussion that should be finished before we can continue label Dec 27, 2020
@mondeja
Copy link
Member

mondeja commented Dec 27, 2020

Should this be marked for deletion in v5.0.0 @simple-icons/maintainers?

Yes, I'm founding a lot of information in other websites about the closing announcement.

@ericcornelissen
Copy link
Contributor

I'd say the relevant question is not whether the announcement is true but whether it has happened yet. As long as it is still active (e.g.. the website is online) when we want to merge this PR I'd say we merge it - it can be removed later if needed. Unfortunately I can't tell if it is still active 😅

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I've been able to find the archived version of the official announcement here which reads the following (in shakily Google Translated):

Due to business adjustments, Tencent Weibo will be held (?) at 23:59 PM on September 28, 2020. ... If necessary, you can back up your relevant information before stopping the service.

Since that announcement visiting the domain presents a login screen, I imagine to forward you back to Tencent's other services. I think the above indicates we're good to set it for removal in v5.0.0, but as @ericcornelissen suggested above, I'm happy for us to merge this fix to the icon until then.

@ericcornelissen
Copy link
Contributor

That seems pretty legitimate, let's hope anyone that speaks Chinese corrects us if necessary.

As for updating or removing it. Now, i'm not quite sure what our approach with this has been so far, but considering #3169 and the possibility of removing the .svglint-ignored.json file we might be better off updating those icons that should be removed first and then (possibly collectively in one PR) remove them in v5. Thoughts?

@fbernhart
Copy link
Contributor Author

So far we've omitted updating them and instead directly marked them ready to be removed.

See: breaking change Issues or pull requests that include a breaking change and scheduled for the next major release

@ericcornelissen
Copy link
Contributor

So far we've omitted updating them and instead directly marked them ready to be removed.

See: breaking change Issues or pull requests that include a breaking change and scheduled for the next major release

I though so, but wasn't sure. I'm fine with that, just unfortunate that we can't remove .svglint-ignore.json until the v5 release.

@adamrusted adamrusted added breaking change Issues or pull requests that include a breaking change and scheduled for the next major release and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Dec 28, 2020
@adamrusted adamrusted added this to the v5.0.0 milestone Dec 28, 2020
@fbernhart fbernhart changed the title Update Tencent Weibo Remove Tencent Weibo Dec 29, 2020
@fbernhart fbernhart marked this pull request as draft December 29, 2020 17:25
@PeterShaggyNoble
Copy link
Member

@fbernhart, could you update the original post to clarify that this PR will remove Weibo, please?

@ericcornelissen ericcornelissen marked this pull request as ready for review May 23, 2021 18:11
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻 Once the conflicts have been resolved, this can be merged straight in.

…into TencentWeibo

� Conflicts:
�	.svglint-ignored.json
@fbernhart fbernhart merged commit a31b0dd into simple-icons:develop May 24, 2021
@fbernhart fbernhart deleted the TencentWeibo branch May 24, 2021 13:52
ericcornelissen added a commit that referenced this pull request May 30, 2021
# Miscellanous

- Add a `DISCLAIMER.md` (#4912)

# NPM Package

- Removed possibility to `simpleIcons.get` an icon by the brand name (#4920)
- You should now start using `simpleIcons.Get` instead of `simpleIcons.get` (#5777)

# New Icons

- GoDaddy (#5773)
- Microsoft Bing (#4744), previously "Bing"
- Replit (#5730), previously "repl.it"
- smash.gg (#5728)
- TietoEVRY (#5685), previously "EVRY"
- Web3.js (#5682)
- WEBTOON (#5381), previously "LINE WEBTOON"

# Updated Icons

- Hulu (#5774)
- Microsoft Azure (#5745)
- Nucleo (#5749)

# Updated Slugs

- .NET (#5611), from "dot-net" to "dotnet"
- A-Frame (#5611), from "a-frame" to "aframe"
- About.me (#5611), from "about-dot-me" to "aboutdotme"
- Alibaba.com (#5611), from "alibaba-dot-com" to "aboutdotme'
- AT&T (#5611), from "at-and-t" to "atandt"
- Audio-Technica (#5611), from "audio-technica" to "audiotechnica"
- B&R Automation (#5611), "b-and-rautomation" to "bandrautomation"
- Battle.net (#5611), from "battle-dot-net" to "battledotnet"
- Blockchain.com (#5611), from "blockchain-dot-com" to "blockchaindotcom"
- Chart.js (#5611), from "chart-dot-js" to "chartdotjs"
- Co-op (#5611), from "co-op" to "coop"
- Conda-Forge (#5611), from "conda-forge" to "condaforge"
- Counter-Strike (#5611), from "counter-srike" to "counterstrike"
- D-Wave Systems (#5611), from "d-wavesystems" to "dwavesystems"
- D3.js (#5611), from "d3-dot-js" to "d3dotjs"
- dev.to (#5611), from "dev-dot-to" to "devdotto"
- diagrams.net (#5611), from "diagrams-dot-net" to "diagramsdotnet"
- Digi-Key Electronics (#5611), from "digi-eyelectronics" to "digikeyelectronics"
- Draugiem.lv (#5611), from "draugiem-dot-lv" to "draugiumdotlv"
- Eclipse Vert.x (#5611), from "eclipsevert-dot-x" to "eclipsevertdotx"
- Ember.js (#5611), from "ember-dot-js" to "emberdotjs"
- F-Droid (#5611), from "f-droid" to "fdroid"
- F-Secure (#5611), from "f-secure" to "fsecure"
- Ferrari N.V. (#5611), rom "ferrarin-dot-v-dot" to "ferrarinv"
- Fraunhofer-Gesellschaft (#5611), from "fraunhofer-gesellschaft" to "fraunhofergesellschaft"
- freedesktop.org (#5611), from "freedesktop-dot-org" to "freedesktopdotorg"
- GOG.com (#5611), from "gog-dot-com" to "gogdotcom"
- Hotels.com (#5611), from "hotels-dot-com" to "hotelsdotcom"
- Itch.io (#5611), from "itch-dot-io" to "itchdotio"
- Ko-fi (#5611), from "ko-fi" to "kofi"
- Last.fm (#5611), from "last-dot-fm" to "lastdotfm"
- Libraries.io (#5611), from "libraries-dot-io" to "librariesdotio"
- Mail.Ru (#5611), from "mail-dot-ru" to "maildotru"
- Material-UI (#5611), from "material-ui" to "materialui"
- Max-Planck-Gesellschaft (#5611), from "max-planck-gesellshaft" to "maxplanckgesellshaft"
- Micro.blog (#5611), from "micro-dot-blog" to "microdotblog"
- MobX-State-Tree (#5611), from "mobx-state-tree" to "mobxstatetree"
- New Japan Pro-Wrestling (#5611), from "newjapanpro-wrestling" to "newjapanprowrestling"
- Next.js (#5611), from "next-dot-js" to "nextdotjs"
- Node-RED (#5611), from "node-red" to "nodered"
- Node.js (#5611), from "node-dot-js" to "nodedotjs"
- Nuxt.js (#5611), from "nuxt-dot-js" to "nuxtdotjs"
- p5.js (#5611), from "p5-dot-js" to "p5dotjs"
- Parse.ly (#5611), from "parse-dot-ly" to "parsedotly"
- Pi-hole (#5611), form "pi-hole" to "pihole"
- Picarto.TV (#5611), from "picatro-dot-tv" to "picartodottv"
- Player.me (#5611), from "player-dot-me" to "playerdotme"
- Pop!_OS (#5073), from "pop_os" to "popos"
- pr.co (#5611), from "pr-dot-co" to "prdotco"
- pre-commit (#5611), from "pre-commit" to "precommit"
- Proto.io (#5611), from "proto-dot-io" to "protodotio"
- protocols.io (#5611), from "protocols-dot-io" to "protocolsdotio"
- Redux-Saga (#5611), from "redux-saga" to "reduxsaga"
- reveal.js (#5611), from "reveal-dot-js" to "revealdotjs"
- Rocket.Chat (#5611), from "rocket-dot-chat" to "rocketdotchat"
- Rolls-Royce (#5611), from "rolls-royce" to "rollsroyce"
- rollup.js (#5611), from "rollup-dot-js" to "rollupdotjs"
- Sat.1 (#5611), from "sat-dot-1" to "sat1"
- scikit-learn (#5611), from "scikit-learn" to "scikitlearn"
- semantic-release (#5611), from "semantic-release" to "semanticrelease"
- Shields.io (#5611), from "shields-dot-io" to "shieldsdotio"
- Socket.io (#5611), from "socket-dot-io" to "socketdotio"
- styled-components (#5611), from "styled-components" to "styledcomponents"
- T-Mobile (#5611), from "t-mobile" to "tmobile"
- Three.js (#5611), from "three-dot-js" to "threedotjs"
- TP-Link (#5611), from "tp-link" to "tplink"
- Trip.com (#5611), from "trip-dot-com" to "tripdotcom"
- ts-node (#5611), from "ts-node" to "tsnode"
- Vue.js (#5611), from "vue-dot-js" to "vuedotjs"
- Warner Bros. (#5611), from "warnerbros-dot" to "warnerbros"
- webcomponents.org (#5611), from "webcomponents-dot-org" to "webcomponentsdotorg"
- Weights & Biases (#5611), from "weights-and-biases" to "weightsandbiases"
- write.as (#5611), from "write-dot-as" to "writedotas"
- X.Org (#5611), from "x-dot-org" to "xdotorg"
- YourTravel.TV (#5611), from "yourtravel-dot-tv" to "yourtraveldottv"
- Z-Wave (#5611), from "z-wave" to "zwave"

# Removed Icons

- Adobe PhoneGap (#5245)
- Automatic (#3982)
- Autotask (#5250)
- Aventrix (#5249)
- Bancontact (#5264)
- Bing (#4744), now "Microsoft Bing"
- Brand.ai (#4365)
- CEVO (#4509)
- ComproPago (#5270)
- Everplaces (#5366)
- EVRY (#4040), now "TietoEVRY"
- FedRAMP (#4046)
- Gauges (#5748)
- GOV.UK (#4060)
- Graphcool (#5602)
- HackHands (#5693)
- Highly (#4243)
- HipChat (#5556)
- HockeyApp (#5038)
- iDEAL (#4577)
- Klout (#5280)
- LINE WEBTOON (#5381), now "WEBTOON"
- Livestream (#4647)
- Mathworks (#5351)
- Monogram (#5345)
- Periscope  (#5415)
- Pingup (#5416)
- Quantopian (#5414)
- repl.it (#5730), now "Replit"
- Sprint (#4710)
- Staticman (#4200)
- Storify (#4204)
- Tencent Weibo (#4222)
- Vine (#5259)
- Virb (#5257)
- X-Pack  (#4239)
- Yandex (#5428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants