Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish 5 new icons and 36 updated icons #4334

Merged
merged 46 commits into from
Dec 13, 2020
Merged

Publish 5 new icons and 36 updated icons #4334

merged 46 commits into from
Dec 13, 2020

Conversation

ericcornelissen
Copy link
Contributor

this Pull Request was automatically generated

The new version will be: v4.2.0

New Icons

Updated Icons

ericcornelissen and others added 30 commits December 6, 2020 19:36
@ericcornelissen
Specify guidelines on (registered) trademarks (#4278)
38137f3 
Specify our guidelines on whether or not to include (registered)
trademark symbols in logos as publically discussed.

This also slightly changes the document structure of the Contributing
Guidelines with the goal of making it a little bit easier to find this
new information.
@fbernhart
Updated Eleventy (#3897)
d529371
@fbernhart
Updated ESEA (#3898)
083deb5 
* Updated ESEA

* Updated ESEA
@fbernhart
Updated Evernote (#3899)
be67f35
@MaxGiting
Add National Grid (#3633)
2c1957e
@fbernhart @mondeja
Updated EyeEm (#3900)
f01c92c 
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
@fbernhart
Updated CRYENGINE (#3894)
d41c67e 
* Updated CRYENGINE

* Updated CRYENGINE

* Fix

* Precision of 5
@fbernhart
Updated Livestream (#3913)
af71717
@fbernhart
Updated Nim (#3923)
2d254ac
@fbernhart
Add Hack The Box (#4254)
b41e06d
@fbernhart
Correct Steinberg (#4203)
4ebacf7
@fbernhart
Update Svelte (#4218)
93a485b 
* Update Svelte

* Precision set to 5

* Rebuilt from source

* Precision of 3
@fbernhart
Updated SlideShare (#3939)
bc0f01e
@fbernhart
Updated Airbus (#3962)
3094085
@fbernhart
Updated Apache (#3967)
bd3b9cf
@fbernhart @mondeja
Update Stylus (#4215)
cc69327 
* Update Stylus

* Precision set to 3

Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
@mondeja
Correct Apache icon (#4294)
6f7c1f5
@fbernhart
Updated Google My Business (#3901)
1d631c8
@fbernhart
Correct Reason Studios (#4180)
f581048 
* Updated Reason Studios

* Rebuilt from source; Precision of 3
@fbernhart
Updated Salesforce (#4185)
089312a 
* Updated Salesforce

* Changed source; Precision is now 3

* Should pass now ...
@fbernhart
Updated Gutenberg (#3904)
7283d61 
* Updated Gutenberg

* Updated Gutenberg

* Rebuilt from source
@PeterShaggyNoble
Add Tutanota (#3375)
8b8fbc9
@fbernhart
Correct Steem (#4201)
a8a6d01 
* Updated Steem

* New icon
@fbernhart
Correct Platzi (#4169)
4c7a8b5
@fbernhart
Updated Anaconda (#3965)
82583e3 
* Updated Anaconda

* Updated Anaconda

* Set precision to 4

* New source; New color; Rebuilt from source

* Resized and recentered again with Inkscape

* Precision of 4

* Resized and recentered again ...

* Precision of 5

* Resized and recentered again ...

* Resized and recentered again ...

* Optimized with Inkscape this time instead of SVGOMG (Precision of 3)

* Using the version of @service-paradis
@fbernhart
Add Snowflake icon (#4089)
e1fa88e 
* Added Snowflake

* Precision of 3
@fbernhart
Correct Humble Bundle (#4071)
cc826ff 
* Updated Humble Bundle

* Rebuilt from source; Precision of 3
@fbernhart
Updated Apache OpenOffice (#3969)
db31649 
* Updated Apache OpenOffice

* Set precision to 4

* Rebuilt from source; Precision of 3

Changed source to https://apache.org/logos

* Without unnecessary points
@fbernhart
Correct Zalando (#3947)
0b54463
@fbernhart
Correct Bamboo (#3992)
65d4d71 
* Updated Bamboo

* Set Precision to 4
fbernhart and others added 15 commits December 10, 2020 19:45
@fbernhart
Correct MicroStrategy (#4104)
04b6981 
* Updated MicroStrategy

* Precision of 3
@fbernhart @mondeja
Update YouTube Music (#4246)
8391a9f 
* Update YouTube Music

* Update YouTube Music

* Remove comma at end of JSON object

Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
@fbernhart
Updated McAfee (#4100)
46d27ba
Add Diagrams.net icon (#4310)
13062e8 
* Added Diagrams.net icon

* Updated Diagrams.net hex to fix linting

* Set precision to 5 - still not perfect

* Did not include correct annotations

* Corrected logo to icon

* Utilized SVGO Command Line Tool - Default Precision

* Used @service-paradis' path output

* Updated from Diagrams.net to diagrams.net - reflects naming convention better.

* Updated SVG title tag
@mondeja
Fix multiple braces in single lines in '_data/simple-icons.json' (#4318)
e4aea98
@fbernhart
Updated NFC (#4111)
3d606f9 
* Updated NFC

* Rebuilt from source; Precision of 3
@fbernhart
Updated HelloFresh (#3907)
3fda138 
* Updated HelloFresh

* Rebuilt from source; changed color; precision of 3
@fbernhart
Updated Nextdoor (#4110)
331c39e 
* Updated Nextdoor

* Rebuilt new icon from source; Changed color; Precision of 3
@fbernhart
Update XFCE (#4241)
7a882c4 
* Update XFCE

* Rebuilt from source; Precision of 4
@fbernhart
Updated Minds (#4105)
d38c334 
* Updated Minds

* Precision of 3
@service-paradis
Update SketchUp icon (#4311)
f518910
@mondeja
Fix errors in website search and remove uneeded statements (#4309)
25213c0 
* Fix error in search and clean website statements

* Remove 'active' class from 'sort-color' sorter

* Add 'order-by-color' class to body

* Remove newlines
@fbernhart
Correct Audiomack (#3981)
8161a03 
* Updated Audiomack

* Precision of 3

* Rebuilt from source; Precision of 4

* No comment
@fbernhart
Updated NEC (#4107)
35d690d 
* Updated NEC

* Precision of 3

* Rebuilt from source; Precision of 3
@fbernhart
Updated NuGet (#4113)
a63f529 
* Updated NuGet

* Set Precision to 5

* Rebuilt from source; Precision of 3

* Rebuilt from source; Precision of 3

* Rebuilt; Precision of 3; Updated source
@ericcornelissen ericcornelissen added the release Pull requests that released a new version label Dec 13, 2020
@github-actions github-actions bot added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both new icon Issues or pull requests for adding a new icon labels Dec 13, 2020
@mondeja
Copy link
Member

mondeja commented Dec 13, 2020

The inclusion of icon outdated and new icon labels could be avoided adding next conditional to the labeler action job?

if: (! contains(github.event.pull_request.labels.*.name, 'release'))

I'm not sure because seems that the release label is added after the pull request creation. What do you think about @ericcornelissen? Maybe this can be improved using another strategy for release label addition?

@ericcornelissen
Copy link
Contributor Author

The inclusion of icon outdated and new icon labels could be avoided adding next conditional to the labeler action job?

if: (! contains(github.event.pull_request.labels.*.name, 'release'))

I'm not sure because seems that the release label is added after the pull request creation. What do you think about @ericcornelissen? Maybe this can be improved using another strategy for release label addition?

As per the GitHub API documentation it is impossible to create a PR (or issue) with a label, and it must always be added separately. You can actually see this when you create an issue with a label from the start, the label (and other things like assigned people) are assigned after the PR/issue is created, even when it is created from a template.

The reason this was not a problem up until #4150 is because that and earlier PR were created using a GITHUB_TOKEN and this PR (as well as #4276) were created using a Personal Access Token of mine. As the usage of the Personal Access Token also prevents the owner of that token from using the release action to merge I think we should consider converting the PR creation back to using a GITHUB_TOKEN and only do the merge using a Personal Access Token. What do you think @simple-icons/maintainers ?

@ericcornelissen ericcornelissen removed update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both new icon Issues or pull requests for adding a new icon labels Dec 13, 2020
@ericcornelissen ericcornelissen merged commit 2514621 into master Dec 13, 2020
@mondeja
Copy link
Member

mondeja commented Dec 13, 2020

I think we should consider converting the PR creation back to using a GITHUB_TOKEN and only do the merge using a Personal Access Token.

Good idea, this should solve the problem 👍

@ericcornelissen ericcornelissen mentioned this pull request Dec 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release Pull requests that released a new version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ericcornelissen @mondeja @fbernhart @MaxGiting @PeterShaggyNoble @service-paradis