New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET #4906
Update .NET #4906
Conversation
Thanks for the PR, @MoDev32. While we're at it, I checked our current icon against the logo in their branding repo and we're going to need to update that as well (see comparison below with our version in red) - do you think you'd be up to taking that on? No problem if not, we can address it separately but I would suggest at least updating this PR to change the source URL to https://github.com/dotnet/brand/ |
I updated the icon source link, but I have never edited an SVG before. So I'll just download it as a black text from this source and optimize it with SVGO if there's a guideline of editing SVGs to be qualified to simple-icons terms, as there are a lot of options regarding the optimization and couldn't find a source related to your preferred options of optimizations. |
Sorry, @MoDev32, I should have linked you to our contributing guidelines, which can be found at https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md For the source, contrary to what those guidelines say, I think we should just go with the repo itself as it contains additional branding information on top of the logo. |
I think I will leave it to you guys. You seem like you could handle this better than me as I've never worked with victors before. I will just change the icon source as you kindly suggested. |
Just pushed an SVG to your branch so we can keep this all together. We will need one of the other @simple-icons/maintainers to review it now, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @MoDev32 and @PeterShaggyNoble 🥳
Issue: Closes #4898
Alexa rank: n/a
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Updated the current used color to the official primary color as mentioned at page 16 of .NET brand guidelines.