Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET #4906

Merged
merged 4 commits into from Feb 2, 2021
Merged

Update .NET #4906

merged 4 commits into from Feb 2, 2021

Conversation

moalamri
Copy link
Contributor

@moalamri moalamri commented Feb 1, 2021

.NET

Issue: Closes #4898
Alexa rank: n/a

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG (Not Necessary)
  • The SVG viewbox is 0 0 24 24

Description

Updated the current used color to the official primary color as mentioned at page 16 of .NET brand guidelines.

Icon updated from this SVG with the circle redrawn.

@moalamri moalamri mentioned this pull request Feb 1, 2021
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Feb 1, 2021

Thanks for the PR, @MoDev32. While we're at it, I checked our current icon against the logo in their branding repo and we're going to need to update that as well (see comparison below with our version in red) - do you think you'd be up to taking that on? No problem if not, we can address it separately but I would suggest at least updating this PR to change the source URL to https://github.com/dotnet/brand/

@PeterShaggyNoble PeterShaggyNoble added changes requested update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both labels Feb 1, 2021
@moalamri
Copy link
Contributor Author

moalamri commented Feb 1, 2021

I updated the icon source link, but I have never edited an SVG before. So I'll just download it as a black text from this source and optimize it with SVGO if there's a guideline of editing SVGs to be qualified to simple-icons terms, as there are a lot of options regarding the optimization and couldn't find a source related to your preferred options of optimizations.

@PeterShaggyNoble
Copy link
Member

Sorry, @MoDev32, I should have linked you to our contributing guidelines, which can be found at https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md

For the source, contrary to what those guidelines say, I think we should just go with the repo itself as it contains additional branding information on top of the logo.

@moalamri
Copy link
Contributor Author

moalamri commented Feb 2, 2021

I think I will leave it to you guys. You seem like you could handle this better than me as I've never worked with victors before. I will just change the icon source as you kindly suggested.

@PeterShaggyNoble PeterShaggyNoble changed the title Updated .NET colour Update .NET Feb 2, 2021
@PeterShaggyNoble
Copy link
Member

Just pushed an SVG to your branch so we can keep this all together. We will need one of the other @simple-icons/maintainers to review it now, though.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MoDev32 and @PeterShaggyNoble 🥳

@adamrusted adamrusted merged commit 2b3bdc1 into simple-icons:develop Feb 2, 2021
ericcornelissen added a commit that referenced this pull request Feb 7, 2021
# New Icons

- dwm (#4891)
- LiveChat (#4871)
- PubMed (#4705)
- Showtime (#4864)
- suckless (#4890)

# Updated Icons

- .NET (#4906)
- Google Chrome (#4525)
- Google Sheets (#4685)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .NET
3 participants