Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New Japan Pro-Wrestling #4930

Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Feb 4, 2021

New Japan Pro-Wrestling

Issue: #2784, #2791 & #4590
Alexa rank: ~43.3k - ~363k - ~38.6k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Found a better quality source which, in turn, claims to be from an official source. Hopefully this one isn't as riddled with imperfections and passes the linter! 馃馃徎

@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Feb 4, 2021
@mondeja mondeja mentioned this pull request Feb 4, 2021
69 tasks
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this icon from .svglint-ignored.json @PeterShaggyNoble?

@PeterShaggyNoble
Copy link
Member Author

Done, @mondeja.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some deformations comparing against the source. It seems that have appeared trying to solve the linting issue. Could you check that @PeterShaggyNoble?

image

@PeterShaggyNoble
Copy link
Member Author

Gonna have to admit defeat here and ask for help; can't figure it out at all 馃

@PeterShaggyNoble
Copy link
Member Author

Managed a workaround but had to increase the precision to 4 as a result.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks spot on! Nice work @PeterShaggyNoble 馃憦

@mondeja mondeja merged commit caef1db into simple-icons:develop Feb 8, 2021
@PeterShaggyNoble PeterShaggyNoble deleted the update/newjapanpro-wrestling branch February 9, 2021 11:10
ericcornelissen added a commit that referenced this pull request Feb 14, 2021
# New Icons

- AOL (#4954)
- Blockchain.com (#4818)
- China Eastern Airlines (#4827)
- Cloudera (#4812)
- D-Wave Systems (#4825)
- Major League Hacking (#4915)
- Oxygen (#4839)
- Pug (#4714)
- Textpattern (#4966)
- Windows Terminal (#4956)

# Updated Icons

- Android Auto (#4400)
- Google Street View (#4683)
- Google Tag Manager (#4586)
- LinkedIn (#4985, #4939)
- New Japan Pro-Wrestling (#4930)
- openSUSE (#4904)
- Roundcube (#4495)
- Svelte (#4907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants