Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prisma #5052

Merged
merged 8 commits into from Feb 18, 2021
Merged

Add Prisma #5052

merged 8 commits into from Feb 18, 2021

Conversation

aadelgrossi
Copy link
Contributor

@aadelgrossi aadelgrossi commented Feb 18, 2021

prisma

Issue: n/a
Alexa rank: #52,881
Github stars: 8.2k https://github.com/prisma/prisma

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon obtained from prisma/presskit
Hex value extracted from website palette (Charcoal 2F3747)

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Feb 18, 2021
@PeterShaggyNoble

This comment has been minimized.

@aadelgrossi

This comment has been minimized.

@PeterShaggyNoble
Copy link
Member

Thanks for the contribution, @aadelgrossi 👍

Which source file did you base your version on? I'm seeing some hairline differences when comparing it to this SVG. Also, for the colour, the closest colour I see in the CSS to the one you've chosen is #2d3748. Finally, as the source repo is a branding repo, could you update the source in the JSON to https://github.com/prisma/presskit?

@PeterShaggyNoble PeterShaggyNoble added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Feb 18, 2021
@aadelgrossi
Copy link
Contributor Author

Thanks for the contribution, @aadelgrossi

Which source file did you base your version on? I'm seeing some hairline differences when comparing it to this SVG. Also, for the colour, the closest colour I see in the CSS to the one you've chosen is #2d3748. Finally, as the source repo is a branding repo, could you update the source in the JSON to https://github.com/prisma/presskit?

I did it based on that one, however I might have wrongly scaled it horizontally by a few pixels because I wasn't managing to get it centered correctly and the lint was failing. I redid it maintaining the original ratio (19.8749px by 24px) and managed to center it properly now. Feel free to check again if there are any differences.

Color hex corrected to #2d3748 as suggested.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, @aadelgrossi, everything looks perfect to me now 👍🏻

Tried to get the precision down to 3 but couldn't either. I'm also not entirely convinced of the colour choice but as they don't really seem to have a clear cut preference for their brand colour I'm going to merge this in as-is and we can update it at a later date, if necessary.

@PeterShaggyNoble PeterShaggyNoble removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Feb 18, 2021
@PeterShaggyNoble PeterShaggyNoble merged commit 4b9ef9b into simple-icons:develop Feb 18, 2021
@aadelgrossi
Copy link
Contributor Author

Thanks for the quick update, @aadelgrossi, everything looks perfect to me now 👍🏻

Tried to get the precision down to 3 but couldn't either. I'm also not entirely convinced of the colour choice but as they don't really seem to have a clear cut preference for their brand colour I'm going to merge this in as-is and we can update it at a later date, if necessary.

Lowering the precision to 3 apparently messes the centering or the icon size itself therefore the linting fails; I struggled immensely yesterday to find that was causing it. Since the precision threshold is 5, I hoped 4 would still be ok for now. Thx for approving and merging!

@aadelgrossi aadelgrossi deleted the add-prisma branch February 18, 2021 16:56
ericcornelissen added a commit that referenced this pull request Feb 21, 2021
# New Icons

- Aerospike (#4994)
- Alibaba.com (#4953)
- ANA (#4821)
- Apache Hive (#4882)
- Aparat (#5046)
- British Airways (#4908)
- ChatBot (#4877)
- Codeberg (#4757)
- Cycling '74 (#4982)
- Databricks (#5037)
- Dogecoin (#4762)
- Ethiopian Airlines (#4909)
- Handshake (#5071)
- Handshake (Protocol) (#5072)
- HelpDesk (#4895)
- Hibernate (#4873)
- Hive (Blockchain) (#3008)
- IEEE (#4989)
- Juniper Networks (#4894)
- Linux Containers (#3155)
- Lion Air (#4959)
- Miro (#5077)
- MobX (#4986)
- MobX-State-Tree (#4984)
- MODX (#4893)
- Naver (#4987)
- OnlyFans (#5059)
- OpenFaaS (#4980)
- Podman (#4774)
- Prisma (#5052)
- Qatar Airways (#4869)
- Resurrection Remix OS (#4756)
- Rider (#5041)
- Sefaria (#4988)
- semantic-release (#4995)
- sharp (#4998)
- Shotcut (#4879)
- teratail (#4897)
- WebdriverIO (#5042)

# Updated Icons

- Citroën (#5005)
- DS Automobiles (#5006)
- GNU (#4945)
- GNU social (#4945)
- Google Play (#4505)
- IconJar (#3909)
- IntelliJ IDEA (#5041)
- Intercom (#5041)
- InVision (#5048)
- Kotlin (#5041)
- Maserati (#5009)
- Opel (#5012)
- Peugeot (#5013)
- PhpStorm (#5041)
- PyCharm (#5041)
- TeamCity (#5041)
- Textpattern (#5065)
- WebStorm (#5041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants