Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ManageIQ #5165

Merged
merged 9 commits into from Jun 3, 2021
Merged

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Mar 4, 2021

image

Issue: #4590
Alexa rank: ~360k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Rebuilt from source and removed next collinear coordinate:

image

@mondeja mondeja added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Mar 4, 2021
@mondeja mondeja mentioned this pull request Mar 4, 2021
69 tasks
@PeterShaggyNoble
Copy link
Member

Thanks, @mondeja. However, that seems to have added a distortion to the inner circle that isn't present in our original.

Also, my reading of the their legal page is that that license applies to their content only, which may not necessarily include their logos and icons. I think, in the interests of not adding this under an incorrect license we should remove it from the JSON for now and reach out to them for clarification.

@mondeja
Copy link
Member Author

mondeja commented Mar 4, 2021

I've given it another try, it should be fine now 🤞

@PeterShaggyNoble
Copy link
Member

The cut-out has gone missing on that latest version, @mondeja.

@mondeja
Copy link
Member Author

mondeja commented Mar 5, 2021

Ups, sorry for the mess 😅 I've restored the gap and removed some useless coordinates.

@PeterShaggyNoble
Copy link
Member

Thanks, @mondeja. Looks like that's introduced some differences (your version in red) in the upper part of the cut-out as well as along the inner circle of the "Q", though, when comparing to this file.

@PeterShaggyNoble
Copy link
Member

Sorry, @mondeja, still seeing a small difference in the top left of the inner edge of the "Q" as well as the right side of the inner circle 🙈

@adamrusted
Copy link
Member

adamrusted commented May 19, 2021

Coming back to this one, I've got the below path optimized to 3 decimals that appears to match up to the source path. @PeterShaggyNoble would you mind having a quick look, and if it does match up, we can merge that path in and get this off @mondeja's list!

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>ManageIQ icon</title><path d="M12.095.1A11.547 11.547 0 0 0 .538 11.659c0 2.069.547 4.005 1.496 5.683l2.869-2.868a7.675 7.675 0 0 1-.54-2.815c0-4.262 3.47-7.73 7.732-7.73s7.732 3.468 7.732 7.73-3.47 7.732-7.732 7.732a7.675 7.675 0 0 1-2.6-.46L6.596 21.83a11.516 11.516 0 0 0 5.499 1.388c2.316 0 4.467-.686 6.275-1.856l2.393 2.392L24 20.512l-2.349-2.349c1.262-1.852 2-4.09 2-6.505 0-6.29-5.007-11.399-11.257-11.557-.081-.003-.181 0-.298 0zm0 9.34c-1.225 0-2.214.991-2.214 2.217s.989 2.215 2.214 2.215a2.214 2.214 0 1 0 0-4.432zm-4.24 3.368-.215.214L0 20.662 3.24 23.9l7.855-7.855-3.24-3.238z"/></svg>

@PeterShaggyNoble
Copy link
Member

Looks good to me, @adamrusted 👍🏻 Although there are a couple of points at the top of the "Q" and the top corner of the rectangle that you may be able to remove.

@adamrusted
Copy link
Member

@PeterShaggyNoble - I've just pushed my updated SVG with the changes you requested. Going to try and work through a few of these to get them off @mondeja's list.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @adamrusted 👍🏻 There's a duplicate point on the our left curve but I couldn't do anything to resolve it either so let's run with it. Thanks to you & @mondeja for your work on this one.

@PeterShaggyNoble PeterShaggyNoble merged commit d94e08d into simple-icons:develop Jun 3, 2021
@mondeja mondeja deleted the update/manageiq branch June 3, 2021 09:36
@mondeja
Copy link
Member Author

mondeja commented Jun 3, 2021

Sorry for not being able to apply the suggestions, I'm a little busy lately. Thanks for finishing the icon update 👍

ericcornelissen added a commit that referenced this pull request Jun 6, 2021
# New Icons

- Construct 3 (#5515)
- Paddy Power (#5744)

# Updated Icons

- ManageIQ (#5165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants