Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Letter R review #5288

Merged
merged 20 commits into from Mar 23, 2021
Merged

Letter R review #5288

merged 20 commits into from Mar 23, 2021

Conversation

service-paradis
Copy link
Member

Issue: #5251

Checklist

  • I updated the JSON data in _data/simple-icons.json

Question

Description

  • Update Rakuten data
    • Add guidelines
  • Update Ram data
    • Add guidelines
  • Update Rancher data
    • Add guidelines
  • Update Raspberry Pi data
    • Add guidelines
    • Update color
  • Update Razer data
    • Update source
  • Update React Router data
    • Update source
  • Update Realm data
    • Update source
  • Update Reason Studios data
    • Add guidelines
  • Update Reddit data
    • Add guidelines
  • Update Redis data
    • Add guidelines
  • Update RedwoodJS data
    • Add guidelines
  • Update Ripple data
    • Add guidelines
  • Update Roam Research data
    • Update source
  • Update Roku data
    • Add guidelines
  • Update Roots data
    • Add guidelines
  • Update ROS data
    • Add guidelines
  • Update RStudio data
    • Add guidelines
  • Update Ruby data
    • Add license
  • Update Runkeeper data
    • Add guidelines
  • Update Rust data
    • Add guidelines
    • Add license

@service-paradis
Update Rakuten data
8b13874 
- Add guidelines
@service-paradis
Update Ram data
ab0eb64 
- Add guidelines
@service-paradis
Update Rancher data
d3914b7 
- Add guidelines
@service-paradis
Update Raspberry Pi data
9c01c13 
- Add guidelines
- Update color
@service-paradis
Update Razer data
3824f79 
- Update source
@service-paradis
Update React Router data
ab5f419 
- Update source
@service-paradis
Update Realm data
7fcee84 
- Update source
@service-paradis
Update Reason Studios data
f6d9a56 
- Add guidelines
@service-paradis
Update Reddit data
ded4e25 
- Add guidelines
@service-paradis
Update Redis data
2a6bd46 
- Add guidelines
@service-paradis
Update RedwoodJS data
8f3b0c0 
- Add guidelines
@service-paradis
Update Ripple data
cb7dfad 
- Add guidelines
@service-paradis
Update Roam Research data
c60aa99 
- Update source
@service-paradis
Update Roku data
f4e11fb 
- Add guidelines
@service-paradis
Update Roots data
81f8594 
- Add guidelines
@service-paradis
Update ROS data
3628d77 
- Add guidelines
@service-paradis
Update RStudio data
8120e5b 
- Add guidelines
@service-paradis
Update Ruby data
6099d62 
- Add license
@service-paradis
Update Runkeeper data
a5d402f 
- Add guidelines
@service-paradis
Update Rust data
680b2d1 
- Add guidelines
- Add license
@adamrusted
Copy link
Member

Yep. Guidelines explicitly state no removal of ® mark. Did you want to look at submitting an update?

  • I'm not sure is I'm looking at the correct RTL. They might have changed their logo?

Looks like we're including this RTL, with the logo matching their Wikipedia page.

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 23, 2021
@service-paradis
Copy link
Member Author

Yep. Guidelines explicitly state no removal of ® mark. Did you want to look at submitting an update?

I dont know if I will find enough time soon for it. I will open a new issue if someone want to take a look at it!

  • I'm not sure is I'm looking at the correct RTL. They might have changed their logo?

Looks like we're including this RTL, with the logo matching their Wikipedia page.

Thank you for your help and thanks Google Translate 😅
Other than in their Wikidata page, I dont find any use of this icon. Is it outdated?

adamrusted
adamrusted approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @service-paradis 🚀

@adamrusted
Copy link
Member

adamrusted commented Mar 23, 2021 •
edited

Other than in their Wikidata page, I dont find any use of this icon. Is it outdated?

Quite possibly. They are a subsidiary of the RTL Group who have one logo, with RTL.de having it's own. I'll merge this PR for now, as the rest of the data is good - but could a German-speaking @simple-icons/maintainers clarify which one we should be using, and open an issue if necessary?

@adamrusted adamrusted merged commit 43ab32c into simple-icons:develop Mar 23, 2021
@github-actions github-actions bot removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 23, 2021
@service-paradis service-paradis deleted the r-review branch March 23, 2021 13:52
@github-actions github-actions bot mentioned this pull request Mar 28, 2021
Merged
ericcornelissen added a commit that referenced this pull request Mar 28, 2021
@ericcornelissen
Release 3 new icons and 114 updated icons (v4.17.0)
59fef74 
# New Icons

- Chart.js (#5229)
- CodeNewbie (#5185)
- Files (#5227)

# Updated Icons

- Dailymotion (#5315)
- Daimler (#5315)
- Dark Reader (#5315)
- Dart (#5315)
- Dash (#5315)
- Dashlane (#5315)
- Dassault Systèmes (#5315)
- Databricks (#5315)
- Datadog (#5315)
- DataStax (#5315)
- Debian (#5315)
- deepin (#5315)
- Deliveroo (#5315)
- Dell (#5315)
- Delphi (#5315)
- Deno (#5315)
- Dependabot (#5315)
- Der Spiegel (#5315)
- Deutsche Bahn (#5315)
- Deutsche Bank (#5315)
- DHL (#5315)
- diagrams.net (#5315)
- Dialogflow (#5315)
- Diaspora (#5315)
- Digg (#5315)
- Digi-Key Electronics (#5315)
- DigitalOcean (#5315)
- Dior (#5315)
- Directus (#5315)
- Kaggle (#5279)
- Kahoot! (#5279)
- KaiOS (#5279)
- Kali Linux (#5279)
- Karlsruher Verkehrsverbund (#5279)
- KDE (#5279)
- KeePassXC (#5279)
- Khan Academy (#5279)
- Khronos Group (#5279)
- Kia (#5279)
- Kik (#5279)
- Kirby (#5279)
- KnowledgeBase (#5279)
- Known (#5279)
- Ko-fi (#5279)
- Kodi (#5279)
- Kofax (#5279)
- Komoot (#5279)
- MongoDB (#5348)
- Nano (#5316)
- NASA (#5316)
- National Grid (#5316)
- NativeScript (#5316)
- Neo4j (#5318, #5316)
- Neovim (#5316)
- NestJS (#5316)
- NetApp (#5316)
- Netflix (#5316)
- Netlify (#5316)
- New Japan Pro-Wrestling (#5316)
- New Relic (#5316)
- New York Times (#5316)
- Nextcloud (#5316)
- Nextdoor (#5316)
- NFC (#5316)
- NGINX (#5316)
- ngrok (#5316)
- Nintendo Network (#5316)
- Nintendo Switch (#5316)
- Nissan (#5316)
- Node.js (#5316)
- Nodemon (#5316)
- NPM (#5316)
- Nrwl (#5316)
- Nubank (#5316)
- Nucleo (#5316)
- NumPy (#5316)
- Nutanix (#5316)
- Nuxt.js (#5316)
- Open Source Initiative (#5286)
- Rakuten (#5288)
- Ram (#5288)
- Rancher (#5288)
- Raspberry Pi (#5288)
- Razer (#5288)
- React (#5288)
- React Router (#5288)
- ReactiveX (#5288)
- Realm (#5288)
- Reason (#5288)
- Reason Studios (#5288)
- Red Hat (#5288)
- Reddit (#5288)
- Redis (#5288)
- Redux (#5288)
- RedwoodJS (#5288)
- Reliance Industries Limited (#5288)
- Renault (#5284)
- Ripple (#5288)
- Riseup (#5288)
- Roam Research (#5288)
- Robot Framework (#5288)
- Roku (#5288)
- Rolls-Royce (#5288)
- Roots (#5288)
- Roots Bedrock (#5288)
- ROS (#5288)
- Rotten Tomatoes (#5288)
- RStudio (#5288)
- RTÉ (#5288)
- Ruby (#5288)
- Ruby on Rails (#5288)
- Runkeeper (#5288)
- RunKit (#5288)
- Rust (#5288)
@PeterShaggyNoble
Copy link
Member

Our RTL icon is for their flagship television channel in Germany. The full colour logo is the one seen on Wikipedia and the brands page linked above. The monochrome treatment which can be seen in the corner of the screen during programmes as well as on subsites such as their gaming site.

Having said all that, our version was recreated from the full colour Wikipedia version as we couldn't find a vector of the monochrome version at the time but, after a little bit more digging this morning, I unearthed this SVG in the footer of this site so we should double check ours lines up with it and update if not. And, while we're at it, we should also check VOX; our version was based on a particularly messy SVG found on Wikipedia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@service-paradis @adamrusted @PeterShaggyNoble