Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter P review #5398

Merged
merged 48 commits into from May 2, 2021
Merged

Letter P review #5398

merged 48 commits into from May 2, 2021

Conversation

service-paradis
Copy link
Member

@service-paradis service-paradis commented Apr 1, 2021

- Add guidelines
- Add guidelines
- Add guidelines
- Add guidelines
- Update source
- Add guidelines
- Update color
- Add guidelines
- Update source
- Update source
- Update source
- Add license
- Add guidelines
- Update source
- Update source
- Update source
- Add license
- Update color
- Add guidelines
- Add guidelines
- Update source
- Add guidelines
- Add guidelines
- Update source
- Add guidelines
- Update source
- Update source
- Update source
- Add guidelines
- Update source
- Add guidelines
- Add guidelines
- Update source
- Update color
- Update source
- Update source
- Update source
- Add guidelines
- Update source
- Add guidelines
- Update source
- Update source
- Update color
- Add guidelines
- Add guidelines
- Add guidelines
- Add guidelines
- Update source
- Add guidelines
- Add license
- Add guidelines
- Update source
- Add guidelines
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think we might need to update paypal.com, logo looks different than the current one

Yep. Agree on this. I think in order to keep it simple and monochrome we should just have the two shapes as if they were opaque, with a 0.5pt gap between them.

Yep. Different to Vine in that the apps have been pulled completely from 31 Mar 21.

👍

I think there's an argument to be made that because of the limited space in our icons, we should stick to the provided App Icon version. What do other @simple-icons/maintainers think?

👍

While the existing treatment we have is easier to read, I think we will have to change it given they've provided an official monochrome treatment.

👍

Looks like our current version matches up to the favicon of the site. I don't think we'd be able to do the logo justice converting it to monochrome (see the issues we had with NASA, where their monochrome treatment was all greys)

As with your other review, I'll convert your original post into a list, so we can track who's doing what from the points you raised.

@PeterShaggyNoble
Copy link
Member

Yep. Agree on this. I think in order to keep it simple and monochrome we should just have the two shapes as if they were opaque, with a 0.5pt gap between them.

Agreed. Although they don't make it available anywhere they themselves have a monochrome version with a similar treatment which can be seen at https://www.paypal.com/uk/webapps/mpp/how-to-use-paypal-here/card-reader

@adamrusted adamrusted mentioned this pull request Apr 16, 2021
3 tasks
This was referenced Apr 16, 2021
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, and all outstanding notes are in progress. Merging in so we get the source/guideline/license info out in this release!

@adamrusted adamrusted merged commit fa70151 into simple-icons:develop May 2, 2021
ericcornelissen added a commit that referenced this pull request May 2, 2021
# New Icons

- Ask Ubuntu (#5148)
- Roblox (#5497)
- Rocket.Chat (#5190)
- ScrollReveal (#5211)
- Tekton (#5445)

# Updated Icons

- Flickr (#5500)
- Let's Encrypt (#5529)
- Pagekit (#5398)
- PagerDuty (#5398)
- pandas (#5398)
- Pantheon (#5398)
- Parse.ly (#5398)
- Patreon (#5398)
- PCGamingWiki (#5398)
- PeerTube (#5398)
- Pelican (#5398)
- Pepsi (#5398)
- Periscope (#5398)
- Phillips Hue (#5398)
- PHP (#5398)
- Pi-hole (#5398)
- Pimcore (#5398)
- Pingdom (#5398)
- Pinterest (#5398)
- Pivotal Tracker (#5398)
- pixiv (#5398)
- PJSIP (#5398)
- PlanGrid (#5398)
- PlayStation (#5398)
- Plesk (#5398)
- Plex (#5398)
- Plurk (#5398)
- Pocket (#5398)
- Polymer Project (#5398)
- PostgreSQL (#5398)
- POWERS (#5398)
- pre-commit (#5398)
- Prettier (#5398)
- Prime (#5398)
- Prime Video (#5398)
- Probot (#5398)
- ProcessWire (#5398)
- Product Hunt (#5398)
- Progress (#5398)
- protocols.io (#5398)
- Proxmox (#5398)
- Publons (#5398)
- PureScript (#5398)
- Python (#5398)
- PyTorch (#5398)
@service-paradis service-paradis deleted the p-review branch May 3, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants