Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update U Brands #5408

Merged
merged 6 commits into from May 13, 2021
Merged

Update U Brands #5408

merged 6 commits into from May 13, 2021

Conversation

adamrusted
Copy link
Member

Issue: Contributes to #5251.

Notes

  • Uber's media assets aren't downloading for me at the moment. May be an issue with the ZIP we need to keep an eye on.
  • Do we need to include the ® on the Ubiquiti logo?

@service-paradis
Copy link
Member

  • Uber's media assets aren't downloading for me at the moment. May be an issue with the ZIP we need to keep an eye on.

image
Using the URL from the console error message (https://newsroomapi.uber.com/wp-content/uploads/2018/09/PNG-20180910T163831Z-001.zip?_ga=2.198979055.1343858345.1617651557-184396900.1617651557), we're able to download the assets. It contains PNG files only though.

  • Do we need to include the ® on the Ubiquiti logo?

I think so according to https://dl.ubnt.com/compliance/Trademark_Guidelines_v2.pdf

Use the appropriate trademark symbol and trademark acknowledgment. Use the ® or ™ symbol in connection with
any Ubiquiti trademark or logo and use the following acknowledgement of Ubiquiti’s ownership: “[insert permissible
mark(s)] [is a/are] registered trademark[s] or trademark[s] of Ubiquiti Networks, Inc. in the United States and other
countries.”
• Do not modif

service-paradis
service-paradis approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this one once we solve the Ubiquiti note 💯

@adamrusted
Copy link
Member Author

@service-paradis I've just updated Ubiquiti - would you mind reviewing that SVG and this can get merged in then 👍🏻

service-paradis
service-paradis requested changes May 11, 2021
View reviewed changes
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Ubiquiti Networks U Logo CMYK .ai file, I got some differences. Mostly in the curve:
image

Can you take another look at it?

In any case you want us to merge the data changes, you could also open a new PR for this icon.

@adamrusted
Copy link
Member Author

Cool, let's scrap the SVG for now - and I'll make a new issue. Feel free to revert my changes to the SVG and merge, providing the JSON is okay.

PeterShaggyNoble
PeterShaggyNoble approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice short one this time 🙂

Thanks, @adamrusted 👍

@PeterShaggyNoble PeterShaggyNoble merged commit ce28ad3 into simple-icons:develop May 13, 2021
@adamrusted adamrusted deleted the Update/U-Brands branch May 13, 2021 11:06
@github-actions github-actions bot mentioned this pull request May 16, 2021
Merged
ericcornelissen added a commit that referenced this pull request May 16, 2021
@ericcornelissen
Release 17 new icons and 71 updated icons (v4.24.0)
06d3a04 
# New Icons

- Alacritty (#5581)
- AllTrails (#5624)
- BookStack (#5141)
- CKEditor 4 (#5159)
- Data Version Control (#5674)
- Eclipse Jetty (#5461)
- Expensify (#5670)
- Grid.ai (#5423)
- JUnit5 (#5644)
- LOT Polish Airlines (#5221)
- osu! (#5347)
- Processing Foundation (#4963)
- PyTorch Lightning (#5663)
- R3 (#5551)
- RxDB (#5622)
- Simkl (#5039)
- Zerodha (#5669)

# Updated Icons

- Apple Music (#5668)
- Consul (#5650)
- del.icio.us (#5047)
- Discord (#5692)
- FARFETCH (#5539)
- Fedora (#5678)
- Feedly (#5539)
- Ferrari (#5539)
- Fido Alliance (#5539)
- FileZilla (#5539)
- Flask (#5539)
- Flickr (#5539)
- Fluentd (#5539)
- Flutter (#5539)
- G2A (#5601)
- Game Jolt (#5601)
- Garmin (#5601)
- Gatsby (#5601)
- Gentoo (#5601)
- Geocaching (#5601)
- Ghost (#5601)
- Ghostery (#5601)
- GIMP (#5601)
- GIPHY (#5601)
- GitBook (#5601)
- Gitee (#5601)
- Glassdoor (#5601)
- GNU Bash (#5601)
- Go (#5601)
- Godot Engine (#5601)
- Google (#5601)
- Google Ads (#5601)
- Google Cast (#5601)
- Google Chrome (#5601)
- Google Fit (#5601)
- Google Hangouts (#5601)
- Google Lens (#5601)
- Google News (#5601)
- Google Pay (#5601)
- Google Photos (#5601)
- Google Play (#5601)
- Google Street View (#5601)
- Gradle (#5601)
- GraphQL (#5601)
- Gravatar (#5601)
- Gridsome (#5601)
- Groupon (#5601)
- Grunt (#5601)
- gulp (#5601)
- HackerRank (#5659)
- Indeed (#5691)
- InfluxDB (#5697)
- Inkscape (#5686)
- Internet Archive (#5698)
- Qgis (#5388)
- Qi (#5388)
- Qiita (#5388)
- Qt (#5388)
- Qualtrics (#5388)
- Quantcast (#5388)
- Quasar (#5388)
- Quest (#5388)
- QuickBooks (#5388)
- Super User (#5694)
- Terraform (#5650)
- Ubiquiti (#5408)
- Ubuntu (#5408)
- Unreal Engine (#5408)
- Untangle (#5408)
- Vagrant (#5650)
- Vault (#5650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@service-paradis service-paradis service-paradis requested changes

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamrusted @service-paradis @PeterShaggyNoble