Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mock Service Worker icon #6166

Merged
merged 11 commits into from Sep 18, 2023
Merged

Add Mock Service Worker icon #6166

merged 11 commits into from Sep 18, 2023

Conversation

arcyopterix
Copy link
Contributor

@arcyopterix arcyopterix commented Jul 25, 2021 •
edited by adamrusted

Issue: Add Mock Service Worker (MSW) icon
Similarweb rank: 893,428
Github stars: 12.8k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Adding MSW icon as requested in issue #6160

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jul 25, 2021
ericcornelissen
ericcornelissen suggested changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Mock Service Worker SVG looks spot on, nice work @arcyopterix! I have one mall request for a change related to the metadata for Mock Service Worker though.

Also, as you already opened #6139 for the Skynet icon, could you remove the file and metadata related to that from this Pull Request? You can get fancy and cherrypick the commits in git, but from our side it's fine if you just remove the file and date in a new commit (this is because we sqaush-and-merge, so the commit history is lost anyway).

_data/simple-icons.json Outdated Show resolved Hide resolved
@ericcornelissen ericcornelissen linked an issue Jul 31, 2021 that may be closed by this pull request
Add Mock Service Worker (MSW) icon #6160
Closed
@adamrusted
Copy link
Member

After a lot of dabbling, I've gotten this PR up to speed with a newer variation of the logo. @simple-icons/icon-review for reference.

mockserviceworker

@adamrusted adamrusted requested a review from LitoMore July 14, 2023 09:39
PratyushJayachandran
PratyushJayachandran approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting the PR @arcyopterix and thanks @adamrusted for finishing it up. Perfect match 🎉

@PratyushJayachandran PratyushJayachandran merged commit 854d8a2 into simple-icons:develop Sep 18, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Sep 24, 2023
Merged
mondeja added a commit that referenced this pull request Sep 24, 2023
@mondeja
Release 4 new icons and 4 updated icons (v9.16.0)
932e249 
# New Icons

- Advent Of Code (#9581)
- Autodesk Revit (#8956)
- Mock Service Worker (#6166)
- OWASP Dependency-Check (#9298)

# Updated Icons

- About.me (#9374)
- Firefish (#9585)
- Home Assistant (#9590)
- PayPal (#9579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen requested changes

@PratyushJayachandran PratyushJayachandran PratyushJayachandran approved these changes

@LitoMore LitoMore Awaiting requested review from LitoMore

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Mock Service Worker (MSW) icon
4 participants
@arcyopterix @adamrusted @ericcornelissen @PratyushJayachandran