Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zyte icon #6578

Merged
merged 2 commits into from Sep 22, 2021
Merged

Add Zyte icon #6578

merged 2 commits into from Sep 22, 2021

Conversation

service-paradis
Copy link
Member

image

Issue: N/A
Alexa rank: ~31k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • I used the footer icon from their website
  • I used Inkscape to scale
  • I used SVGOMG to optimize
  • I used the color embedded in the icon and found in their website

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 21, 2021
@jorgeamadosoria
Copy link
Contributor

image

100% match from me, feel free to merge it @service-paradis

@service-paradis service-paradis merged commit 4c84db0 into simple-icons:develop Sep 22, 2021
@service-paradis service-paradis deleted the add-zyte branch September 22, 2021 13:17
@github-actions github-actions bot mentioned this pull request Sep 26, 2021
Merged
ericcornelissen added a commit that referenced this pull request Sep 26, 2021
@ericcornelissen
Release 8 new icons and 9 updated icons (v5.16.0)
43f7f59 
# New Icons

- Dataiku (#6305)
- MediaMarkt (#6573)
- phpMyAdmin (#6579)
- Pulumi (#6547)
- PWA (#6031)
- Skynet (#6367)
- Zcash (#6312)
- Zyte (#6578)

# Updated Icons

- Kotlin (#6577)
- Talend (#6568)
- Tata (#6554)
- Tesla (#6554)
- Thunderbird (#6554)
- Thymeleaf (#6554)
- TinyLetter (#6554)
- Topcoder (#6554)
- TurboSquid (#6554)
@adsingh14
Copy link
Contributor

image
Can you please fix this ?

@jorgeamadosoria
Copy link
Contributor

image Can you please fix this ?

did you check if the data file has a trailing empty line?
If the json fine does not end in a trailing empty line it will throw that error, and you will see zyte because it's the last icon, not because it is the root cause of the problem.

@adsingh14
Copy link
Contributor

I fixed it manually.
Can you tell me how to run it locally ?
I get these errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@service-paradis @jorgeamadosoria @adsingh14