Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jetpack Compose #6983

Merged
merged 4 commits into from Dec 27, 2021
Merged

Add Jetpack Compose #6983

merged 4 commits into from Dec 27, 2021

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Dec 25, 2021 •
edited

image

Issue: Closes #6982
Alexa rank: N/A

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Geometry recreated from scratch because SVG of the official source is a mess. I've picked 0,3 px for straight line gaps and 3,5px of radius for hexagons (using Inkscape).
  • Color picked from source SVG.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 25, 2021
@mondeja mondeja mentioned this pull request Dec 25, 2021
Merged
3 tasks
@jorgeamadosoria
Copy link
Contributor

I took the SVG from the original source and isolated the icon.
the code is this
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Jetpack Compose</title><path d="M11.887 0a2.415 2.415 0 0 0-1.21.337h-.001L2.347 5.14a2.248 2.248 0 0 0-.839.92l4.039 2.25c.018-.032.039-.063.059-.094.008-.012.014-.025.022-.036a1.44 1.44 0 0 1 .45-.444l5.049-2.911c.095-.056.194-.096.296-.13.164-.057.335-.09.507-.091a1.6 1.6 0 0 1 .798.203l5.071 2.858a1.534 1.534 0 0 1 .527.487h.001l.778-.447c1.257-.726 2.742-1.585 3.222-1.853a2.459 2.459 0 0 0-.85-.822L13.104.314A2.443 2.443 0 0 0 11.887 0Zm.044 4.754a1.444 1.444 0 0 0-.717.2l-5.046 2.91a1.183 1.183 0 0 0-.147.104 1.415 1.415 0 0 0-.333.416l1.13.626.862.43.006-.012v-.002l.003-.002.038-.058.002-.004.003-.003c.03-.036.064-.074.098-.108a.992.992 0 0 1 .183-.138l3.382-1.95a1.159 1.159 0 0 1 .317-.124l.006-.002h.006c-.008 0 .003-.004.03-.006a.684.684 0 0 1 .097-.013c.034-.004.062-.005.08-.007l.006-.001h.005c.047 0 .094.005.139.009h.004c.068.01.134.024.206.047.05.014.094.034.134.052l.005.003.005.003c.007.005.029.01.06.03l3.398 1.914c.133.077.236.188.327.307l.357-.202.538-.31s.472-.273 1.071-.624a1.442 1.442 0 0 0-.473-.442l-5.07-2.86a1.412 1.412 0 0 0-.633-.174c-.026-.001-.052-.01-.08-.01zm10.476 1.225c-.26.145-1.127.648-1.792 1.03l-2.206 1.27.002.003-.013.007a1.552 1.552 0 0 1 .202.75l.04 4.58.013 1.524c.001.146-.028.287-.08.416l-.03.062c-.009.017-.016.035-.026.052a1.09 1.09 0 0 1-.397.413l-5.301 3.057a1.746 1.746 0 0 1-.673.23v.01l.042 3.74.01.862c.365-.043.73-.158 1.069-.36l8.755-5.048c.487-.287.785-.81.78-1.378l-.09-10.082a2.439 2.439 0 0 0-.306-1.14Zm-20.969.217a2.745 2.745 0 0 0-.241 1.128l.086 9.602c.008.867.48 1.661 1.236 2.086l8.368 4.72a2.14 2.14 0 0 0 1.162.264l-.01-.843-.045-3.764a1.417 1.417 0 0 1-.736-.179l-5.071-2.859a1.563 1.563 0 0 1-.475-.407 1.606 1.606 0 0 1-.34-.965l-.05-5.816c0-.036.005-.073.007-.11.002-.038.003-.076.007-.113l.002-.012c.02-.17.066-.333.127-.487Zm16.83 2.177c-.61.352-1.083.63-1.083.63l-.517.29-.365.21a1.137 1.137 0 0 1 .134.503l.038 4.097a.71.71 0 0 1-.097.37v.002a.811.811 0 0 1-.185.218.616.616 0 0 1-.085.057l-3.554 2.05c-.037.02-.08.044-.124.063a1.17 1.17 0 0 1-.273.08l-.03 1.073.004.27.014.926a1.61 1.61 0 0 0 .602-.206l5.301-3.057c.017-.01.033-.022.05-.033a.95.95 0 0 0 .282-.3c.016-.03.025-.061.038-.092a.924.924 0 0 0 .085-.371v-.001l-.013-1.527-.044-4.591a1.47 1.47 0 0 0-.178-.66Zm-12.663.152c-.014.034-.024.07-.037.105a1.582 1.582 0 0 0-.076.302l-.005.032a1.364 1.364 0 0 0-.012.202l.05 5.815a1.437 1.437 0 0 0 .08.45c.012.034.022.068.036.1a1.425 1.425 0 0 0 .617.685l5.07 2.86c.215.115.437.16.664.154l-.015-1.216v-.042l.029-1h-.042a1.38 1.38 0 0 1-.135-.009h-.003a1.02 1.02 0 0 1-.345-.113h-.001l-3.402-1.915h-.001a1.281 1.281 0 0 1-.227-.17l-.006-.004-.005-.005a1.037 1.037 0 0 1-.125-.15l-.002-.001-.002-.003c-.008-.014-.023-.03-.041-.06l-.034-.06-.001-.001-.001-.002a1.21 1.21 0 0 1-.096-.266v-.003a.916.916 0 0 1-.021-.22l-.034-3.893c-.002-.07.004-.14.015-.208a1.35 1.35 0 0 1 .05-.203l.002-.002c.014-.037.03-.074.047-.11l-.873-.43Z"/></svg>

It's pretty much the same, but the separators are thinner and it is not handmade, it's the same SVG than the page minus all the extraneous elements.

@mondeja
Copy link
Member Author

mondeja commented Dec 26, 2021

Not sure what could be the best treatment here. Looks good but I'm seeing a lot of uneeded coordinates. For example at the top of the inner part of the hexagon:

Your version
image

My version
image

@jorgeamadosoria
Copy link
Contributor

Not sure what could be the best treatment here. Looks good but I'm seeing a lot of uneeded coordinates. For example at the top of the inner part of the hexagon:

Your version image

My version image

I mean, yours is made by hand, and mine is extracted from the page. You would expect that yours had less points and better symmetry than the busy svg. It's normal.

The best treatment is to simplify the path in inkscape. It may or may not generate visible discrepancies. In a simple geometric figure like this a simplify operation shouldn't add noise.

In any case, I'm more concerned about sourcing than the path of the icon. You can just commit yours and move on. It looks good.

@mondeja mondeja merged commit 907d806 into simple-icons:develop Dec 27, 2021
@mondeja mondeja deleted the add/jetpack-compose branch December 27, 2021 03:33
@github-actions github-actions bot mentioned this pull request Jan 2, 2022
Merged
mondeja added a commit that referenced this pull request Jan 2, 2022
@mondeja
Release 1 new icon and 6 updated icons (v6.5.0)
163e1ed 
# New Icons

- Jetpack Compose (#6983)

# Updated Icons

- Apache JMeter (#7000)
- Chromecast (#6512)
- Font Awesome (#7011, #6290)
- Google Classroom (#6512)
- Teespring (#6559)
- YouTube (#7001)
@sachinraja sachinraja mentioned this pull request Jan 19, 2022
Closed
@pavi2410 pavi2410 mentioned this pull request Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Jetpack Compose
2 participants
@mondeja @jorgeamadosoria