Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases support for add-icon-data script #7863

Merged
merged 5 commits into from Sep 28, 2022

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Sep 25, 2022

Related to #7849

The aliases field is more complicated. We may need a bunch of questions to collect users' inputs.

Here is the type overview:

type Aliases = {
	aka?: string[];
	dup?: SimpleIcon[];
	loc?: Record<langageCode, string>;
	old?: string[];
}

Maybe we could add a tip to contributing doc to let users modify the _icons/simple-icons.json directly.

@LitoMore LitoMore marked this pull request as draft September 25, 2022 05:24
@LitoMore LitoMore added the meta Issues or pull requests regarding the project or repository itself label Sep 25, 2022
@LitoMore
Copy link
Member Author

LitoMore commented Sep 27, 2022

@mondeja Any thoughts about this? If we need to add aliases support, we will need to add a lot of prompts.

The loc, requires users to select some languages with checkboxes, then performs some prompts to accept the user's inputs.

@LitoMore LitoMore marked this pull request as ready for review September 27, 2022 18:48
scripts/utils.js Outdated Show resolved Hide resolved
scripts/add-icon-data.js Outdated Show resolved Hide resolved
@mondeja
Copy link
Member

mondeja commented Sep 27, 2022

It works nice 🌟 Seems like adding the loc field is not too much useful for the script, maybe in the future.

Feel free to merge it after resolve the suggestions 🔧

LitoMore and others added 4 commits September 28, 2022 09:53
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
@LitoMore LitoMore merged commit 3b141f1 into simple-icons:develop Sep 28, 2022
@LitoMore LitoMore deleted the add-aliases-field branch September 28, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants