Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaddlePaddle icon #8461

Merged
merged 12 commits into from Apr 3, 2023
Merged

Add PaddlePaddle icon #8461

merged 12 commits into from Apr 3, 2023

Conversation

geoyee
Copy link
Contributor

@geoyee geoyee commented Mar 24, 2023

paddlepaddle

Issue: closes #8460

Similarweb rank:

Global Rank is 124,703 and Github star is 19.9k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I have vectorized the official PNG using Illustrator

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 24, 2023
@LitoMore
Copy link
Member

LitoMore commented Apr 2, 2023

@geoyee Could you please ask their team to provide an original vector version of the logo?

@geoyee
Copy link
Contributor Author

geoyee commented Apr 2, 2023 via email

@geoyee
Copy link
Contributor Author

geoyee commented Apr 3, 2023

@LitoMore This is original vector logo from their team

image

I changed Circle to Path and modified it as required by sample-icons

paddlepaddle

@LitoMore
Copy link
Member

LitoMore commented Apr 3, 2023

Thank you, @geoyee! Would you mind pasting the original SVG here in case we can review this?

@geoyee
Copy link
Contributor Author

geoyee commented Apr 3, 2023

Thank you, @geoyee! Would you mind pasting the original SVG here in case we can review this?

it is a .ai file, do you means export SVG by illustrator?

@LitoMore
Copy link
Member

LitoMore commented Apr 3, 2023

@geoyee OK, then please share the .ai file directly. You could pack it to .zip and then upload it to your comment.

@geoyee
Copy link
Contributor Author

geoyee commented Apr 3, 2023

@geoyee OK, then please share the .ai file directly. You could pack it to .zip and then upload it to your comment.

of course PaddlePaddle-CMYK.zip

@LitoMore
Copy link
Member

LitoMore commented Apr 3, 2023

CleanShot 2023-04-03 at 16 32 24@2x

@geoyee I found some differences.

The expected size should be:

CleanShot 2023-04-03 at 16 34 43@2x

But yours:

CleanShot 2023-04-03 at 16 35 26@2x

Could you recheck this?

@geoyee
Copy link
Contributor Author

geoyee commented Apr 3, 2023

CleanShot 2023-04-03 at 16 32 24@2x

@geoyee I found some differences.

The expected size should be:

CleanShot 2023-04-03 at 16 34 43@2x

But yours:

CleanShot 2023-04-03 at 16 35 26@2x

Could you recheck this?

ok, you are so careful 😃

@geoyee
Copy link
Contributor Author

geoyee commented Apr 3, 2023

this is the error between the two images after update

error

@geoyee
Copy link
Contributor Author

geoyee commented Apr 3, 2023

this is the error between the two images after update

error

i am certain that i can not achieve a better result. i have tried multiple times 😭

@LitoMore
Copy link
Member

LitoMore commented Apr 3, 2023

@geoyee Because it loses precision when you convert .ai to .svg.

Could you try Inkscape? The Inkscape allows selecting the precision when importing the .ai file to the canvas. The precision 2.0 is enough to use.

CleanShot 2023-04-03 at 18 31 25@2x

@geoyee
Copy link
Contributor Author

geoyee commented Apr 3, 2023 via email

@geoyee
Copy link
Contributor Author

geoyee commented Apr 3, 2023

@LitoMore done, i am sorry for taking up so much time. i am not familiar with using Inkscape, especially when its exported plain SVG files can not be displayed directly. i believe that this logo file is ok 😄

Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2023-04-03 at 22 58 41@2x

@geoyee Perfect fit now! Thank you for your contribution!

@LitoMore LitoMore merged commit 0816325 into simple-icons:develop Apr 3, 2023
3 checks passed
mondeja added a commit that referenced this pull request Apr 9, 2023
# New Icons

- CircuitVerse (#8489)
- OSGeo (#8464)
- PaddlePaddle (#8461)
- Poe (#8502)
- YAML (#8519)

# Updated Icons

- Netlify (#8445)
- Steam Deck (#8515)
- Wise (#8447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: PaddlePaddle
2 participants