Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RISC-V icon #8778

Merged
merged 9 commits into from Jul 6, 2023
Merged

Add RISC-V icon #8778

merged 9 commits into from Jul 6, 2023

Conversation

PratyushJayachandran
Copy link
Member

riscv

Issue: closes #8777

Similarweb rank: 406,735. See https://www.similarweb.com/website/riscv.org

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Hex Value picked from logo: #FFC72C
Logo provided as an EPS by the brand itself. Isolated logo and converted to monochromatic SVG.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 11, 2023
@PratyushJayachandran
Copy link
Member Author

PratyushJayachandran commented Jun 11, 2023 •
edited

Running into this error on local, even on develop branch

Checking formatting...
[warn] scripts\add-icon-data.js
[warn] Code style issues found in the above file. Forgot to run Prettier?
ERROR: "jslint" exited with 1.

But checks seem to have passed on GitHub

@PratyushJayachandran PratyushJayachandran changed the title #8777 add risc v logo Add RISC-V logo Jun 12, 2023
@PratyushJayachandran PratyushJayachandran changed the title Add RISC-V logo Add RISC-V Jun 12, 2023
@PratyushJayachandran
Copy link
Member Author

I am not able to see the additional information I added about RISC-V. I don't know if the maintainers can see it. If needed, please leave a comment and I will be happy to add more details.
Basically RISC-V is an open-source Instruction Set Architecture (ISA) that has existed alongside proprietary ISAs like x86, ARM and AMD64. Find more info here: https://riscv.org/about/

LitoMore
LitoMore requested changes Jun 27, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@PratyushJayachandran @LitoMore
Update _data/simple-icons.json based on review comments
3e5d4ee 
Co-authored-by: LitoMore <LitoMore@users.noreply.github.com>
LitoMore
LitoMore requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I found some differences. Could you point out which asset are you using as reference?

I used the Tall_2.eps as reference.

image

@PratyushJayachandran
Copy link
Member Author

I found some differences. Could you point out which asset are you using as reference?

I used Standard-Black_2.eps and there seems to be some difference from Tall_2.eps
image

Which one should I use?

@PratyushJayachandran
Copy link
Member Author

Which one should I use?

@LitoMore

@LitoMore
Copy link
Member

LitoMore commented Jul 6, 2023

Hmmm. It seems that we don't need to be too entangled. This difference is not a big deal.

@LitoMore LitoMore changed the title Add RISC-V Add RISC-V icon Jul 6, 2023
@LitoMore LitoMore merged commit 83110c1 into simple-icons:develop Jul 6, 2023
4 checks passed
@PratyushJayachandran PratyushJayachandran deleted the #8777-Add-RISC-V-logo branch July 6, 2023 15:03
@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
mondeja added a commit that referenced this pull request Jul 9, 2023
@mondeja
Release 7 new icons and 17 updated icons (v9.5.0)
3d8e2be 
# New Icons

- Ariakit (#8946)
- Pretzel (#6081)
- Recoil (#5998)
- RISC-V (#8778)
- Sitecore (#8950)
- Threads (#8943)
- Wasabi (#8952)

# Updated Icons

- BBC (#8596)
- BBC iPlayer (#8596)

# Metadata Update

- Microsoft Access (#8909)
- Microsoft Azure (#8909)
- Microsoft Excel (#8909)
- Microsoft Exchange (#8909)
- Microsoft Office (#8909)
- Microsoft OneDrive (#8909)
- Microsoft OneNote (#8909)
- Microsoft Outlook (#8909)
- Microsoft PowerPoint (#8909)
- Microsoft SharePoint (#8909)
- Microsoft SQL Server (#8909)
- Microsoft Teams (#8909)
- Microsoft Translator (#8909)
- Microsoft Visio (#8909)
- Microsoft Word (#8909)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RISC-V logo
2 participants
@PratyushJayachandran @LitoMore