Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Proton Mail icon #8882

Merged
merged 8 commits into from Jun 29, 2023
Merged

Update Proton Mail icon #8882

merged 8 commits into from Jun 29, 2023

Conversation

PratyushJayachandran
Copy link
Member

protonmail

Issue: closes #8649

Similarweb rank: 137,199. See https://www.similarweb.com/website/protonmail.com

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from Official Icons in Brand website https://proton.me/media/kit
Color: #9d82ff Taken from averaging logo colors by square root method.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jun 25, 2023
@LitoMore
Copy link
Member

Duplicate of #7793

@LitoMore LitoMore marked this as a duplicate of #7793 Jun 26, 2023
@LitoMore
Copy link
Member

LitoMore commented Jun 26, 2023 •
edited

We can still review and merge this PR. And update the title in another PR then mark the title change as a breaking change.

@LitoMore
Copy link
Member

Let's try with a 2px gap. 2px will be a better look.

LitoMore
LitoMore reviewed Jun 26, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@PratyushJayachandran
Copy link
Member Author

Let's try with a 2px gap. 2px will be a better look.

2px seemed to be a bit much. I did a 1px gap. It looks good to me. What is your opinion?
protonmail

@PratyushJayachandran
Copy link
Member Author

We can still review and merge this PR. And update the title in another PR then mark the title change as a breaking change.

I didn't understand this part.

By the way I created this PR as I saw that old PR was stuck at requested change for too long.

@LitoMore
Copy link
Member

See https://github.com/simple-icons/simple-icons/blob/develop/VERSIONING.md.

@PratyushJayachandran
Copy link
Member Author

See https://github.com/simple-icons/simple-icons/blob/develop/VERSIONING.md.

Oh now I get it. You were taking about the title in JSON. So we will be putting a space between Proton and Mail?
If we are doing that, that will be part of a Major release, correct?

@LitoMore
Copy link
Member

Correct.

LitoMore
LitoMore approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good.

@LitoMore LitoMore changed the title Update Proton Mail Update Proton Mail icon' Jun 29, 2023
@LitoMore LitoMore changed the title Update Proton Mail icon' Update Proton Mail icon Jun 29, 2023
@LitoMore LitoMore merged commit c7c2543 into simple-icons:develop Jun 29, 2023
3 checks passed
@LitoMore
Copy link
Member

@PratyushJayachandran We could update the Proton Drive to 2px gap as well.

And the Proton Calendar needs to be added to our library. PRs welcome.

image

@PratyushJayachandran
Copy link
Member Author

@PratyushJayachandran We could update the Proton Drive to 2px gap as well.

And the Proton Calendar needs to be added to our library. PRs welcome.
image

Proton Calendar PR: #8883

Proton Drive: Soon™️

@PratyushJayachandran PratyushJayachandran deleted the Update-Proton-Mail-#8649 branch June 29, 2023 06:41
@github-actions github-actions bot mentioned this pull request Jul 2, 2023
Merged
mondeja added a commit that referenced this pull request Jul 2, 2023
@mondeja
Release 8 new icons and 7 updated icons (v9.4.0)
3802508 
# New Icons

- Chia Network (#8673, #8906)
- DTS (#8853)
- Elavon (#6286)
- Mikrotik (#8886)
- Nikon (#8870)
- Termius (#8885)
- Vega (#8089)
- Viva Wallet (#6288)

# Updated Icons

- New Relic (#8800)
- Nokia (#8392)
- Obsidian (#8729)
- ProtonMail (#8882)
- ProtonVPN (#8880)
- Sauce Labs (#8923)
- Twitter (#8873)
- Volvo (#8884)
@adamrusted adamrusted mentioned this pull request Jul 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proton Mail is outdated
2 participants
@PratyushJayachandran @LitoMore