Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScyllaDB #9270

Merged
merged 37 commits into from
Aug 25, 2023
Merged

Add ScyllaDB #9270

merged 37 commits into from
Aug 25, 2023

Conversation

Grifed-source
Copy link
Contributor

@Grifed-source Grifed-source commented Aug 12, 2023 •
edited by service-paradis

Issue: closes #9254

Similarweb rank: 278,478. See https://www.similarweb.com/website/scylladb.com/#overview

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from https://www.scylladb.com/media-kit/
Color Taken from major color in logo #6CD5E7
The logo outline colour is: #3D355C

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 12, 2023
adamrusted
adamrusted reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use your branch as a source.
The brand guidelines would also suggest we cannot use a custom treatment of the mascot.
Would you like to reach out to the ScyllaDB team directly, @Grifed-source?

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 15, 2023
@Grifed-source
Copy link
Contributor Author

Grifed-source commented Aug 15, 2023 •
edited

Hey ! It's not really a modified version, in the brand kit they give the black and white version as an svg, I only changed the the Svg Viewbox. Is that count as an modified version ?

@adamrusted
Copy link
Member

Ah, fair enough. I would link to the media kit page as your source then - and it would appear there are some differences between your PR in black, and logo-scylla-vertical-1-color-black-RGB.svg in red.

@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 15, 2023
@adamrusted
Copy link
Member

I'm talking to someone at ScyllaDB right now, i keep you updated

Amazing. See what they come back with.

@Grifed-source
Copy link
Contributor Author

Hey I got the reply, they're allowing me to use the logo

@adamrusted
Copy link
Member

Amazing. If you could refine based on the differences I found above, I'll look to get this one merged in.

adamrusted
adamrusted requested changes Aug 16, 2023
View reviewed changes
icons/scylladb.svg Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
Grifed-source and others added 4 commits August 16, 2023 11:59
@Grifed-source
Remove of the style element
1dfcbef
@Grifed-source
Update _data/simple-icons.json
07c1236 
Co-authored-by: Adam Rusted <hello@adamrusted.me>
@Grifed-source
Update _data/simple-icons.json
5a0d561 
Co-authored-by: Adam Rusted <hello@adamrusted.me>
@Grifed-source
Remove new line character
af53de0
adamrusted
adamrusted reviewed Aug 16, 2023
View reviewed changes
icons/scylladb.svg Outdated Show resolved Hide resolved
Grifed-source and others added 2 commits August 16, 2023 12:08
@Grifed-source
Update icons/scylladb.svg
f94f279 
Co-authored-by: Adam Rusted <hello@adamrusted.me>
@Grifed-source
Remove the newline character
3726bfd
@adamrusted
Copy link
Member

Let me take a look at this one, @Grifed-source - not sure why the linter etc is failing... I'll push an update to it shortly.

@Grifed-source
Copy link
Contributor Author

I don't know why but when i commit your suggestions it adds a new line character

@adamrusted
Copy link
Member

Weird. I'll see if I can fix it locally without making any material changes...

adamrusted
adamrusted requested changes Aug 16, 2023
View reviewed changes
icons/scylladb.svg Show resolved Hide resolved
@adamrusted
Copy link
Member

I think it might have something to do with editor config adding a new line. Let me update again to remove properly.

@Grifed-source
Copy link
Contributor Author

Grifed-source commented Aug 16, 2023 •
edited

image
it's weird, when I modify the file from the Github editor it tells me unexpected newline character but it shows me that I only have one line

@adamrusted
Copy link
Member

Can another member of @simple-icons/icon-review please review this one, now I've contributed?

service-paradis
service-paradis approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to both of you 🎉

@service-paradis service-paradis merged commit 791240a into simple-icons:develop Aug 25, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 27, 2023
Merged
mondeja added a commit that referenced this pull request Aug 27, 2023
@mondeja
Release 12 new icons and 16 updated icons (v9.12.0)
35d2ba4 
# New Icons

- Alby (#9015)
- Alienware (#9408)
- Falco (#8770)
- Flux (#9355)
- Google Slides (#9317)
- Gradle Play Publisher (#9350)
- MarvelApp (#9389)
- ScyllaDB (#9270)
- Shortcut (#9329)
- SpigotMC (#9308)
- Vespa (#9291)
- Wellfound (#8832)

# Updated Icons

- Angular (#9266)
- Apache Cassandra (#9271)
- BandLab (#9339)
- Bandsintown (#9340)
- Bun (#9316)
- Fila (#9176)
- OpsLevel (#9388)
- QuantConnect (#9400)
- Quasar (#9413)
- QuickLook (#9331)
- Venmo (#6284)
- VSCodium (#9399)
- Webflow (#9407)
- Wix (#9406)
- Yelp (#9382)
- Zapier (#9191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted requested changes

@service-paradis service-paradis service-paradis approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add icon: ScyllaDB
3 participants
@Grifed-source @adamrusted @service-paradis