Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefish #9426

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Add Firefish #9426

merged 2 commits into from
Aug 28, 2023

Conversation

coxde
Copy link
Contributor

@coxde coxde commented Aug 27, 2023

firefish

Issue: closes #9425

Similarweb rank: 362,392

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Since the official logo is gradient, I just picked the gold one from four accent colors, which looks close-ish to the original logo.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 27, 2023
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aced it with the logo @coxde - looks perfect!
Just one suggestion on the JSON, but otherwise this is good to go! 🎉

_data/simple-icons.json Outdated Show resolved Hide resolved
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on. Thanks @coxde! 🎉

@adamrusted adamrusted merged commit c44c0a7 into simple-icons:develop Aug 28, 2023
5 checks passed
mondeja added a commit that referenced this pull request Sep 3, 2023
# New Icons

- Docusaurus (#9314)
- Firefish (#9426)
- ISC2 (#9419)
- OpenTF (#9441)
- Scrapbox (#9421)
- Uno (#6306)

# Updated Icons

- Behance (#9347)
- Delphi (#9436)
@ThatOneCalculator
Copy link
Contributor

Unrelated question: how are those preview cards made?

Also, thank you for adding my project! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Firefish
3 participants