Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rocket icon #9492

Merged
merged 15 commits into from Apr 3, 2024
Merged

Add Rocket icon #9492

merged 15 commits into from Apr 3, 2024

Conversation

IamRezaMousavi
Copy link
Contributor

@IamRezaMousavi IamRezaMousavi commented Sep 4, 2023 •
edited

rocket

Issue: closes #8185

21.4k GitHub ⭐

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Did you manually vectorize the logo? No

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 4, 2023
@adamrusted
Copy link
Member

Hey @SergioBenitez - you wouldn't happen to have an SVG/AI version of the icon shown above would you?
It'd be ace to include the original icon as opposed to one of our contributors having to manually vectorize it!

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Sep 5, 2023
@adamrusted
Copy link
Member

I don't see the version with the trails behind the rocket used in the current source code of the homepage. We might just need to use the boxed rocket without the trails.

@SergioBenitez
Copy link

Here's everything:

logo-small
logo
logo-boxed
favicon
rocket-logo@2x
rocket-logo@3x

@IamRezaMousavi
Copy link
Contributor Author

@adamrusted What do I need to do?

@PeterShaggyNoble
Copy link
Member

@IamRezaMousavi, can you redo your SVG based on this one provided above, please?

@PeterShaggyNoble PeterShaggyNoble added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Nov 22, 2023
@IamRezaMousavi
Copy link
Contributor Author

@IamRezaMousavi, can you redo your SVG based on this one provided above, please?

@PeterShaggyNoble How is it now?

adamrusted
adamrusted reviewed Nov 22, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
PeterShaggyNoble
PeterShaggyNoble requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @IamRezaMousavi, I should have been clearer: it's that version we should be using but with the square. Like so:
image

@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @IamRezaMousavi?

@IamRezaMousavi
Copy link
Contributor Author

Are you still working on this one, @IamRezaMousavi?

I think Rocket is not qualified for your new review metrics

Please see similarweb ranking

@adamrusted
Copy link
Member

I think Rocket is not qualified for your new review metrics

SimilarWeb rank of 306,696 puts this in scope!

@adamrusted
Copy link
Member

Given it's still in scope - are you able to make the changes requested, @IamRezaMousavi?

@adamrusted adamrusted added the abandoned Pull requests that have been abandoned by the contributor label Feb 21, 2024
@IamRezaMousavi
Copy link
Contributor Author

IamRezaMousavi commented Mar 6, 2024 •
edited

Sorry, @IamRezaMousavi, I should have been clearer: it's that version we should be using but but with the square. Like so: image

I think you wrong about this
Please check the svg again

@IamRezaMousavi
Copy link
Contributor Author

I redid the logo based on this one

@mondeja mondeja removed the abandoned Pull requests that have been abandoned by the contributor label Mar 9, 2024
@adamrusted adamrusted requested review from a team and removed request for adamrusted and PeterShaggyNoble March 9, 2024 21:08
PratyushJayachandran
PratyushJayachandran requested changes Mar 9, 2024
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please re-do from the logo-small.svg from their official website?
Thank you for your persistent efforts @IamRezaMousavi 😄

icons/rocket.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a slight bit of scaling issue which could also be due to SVG optimization. See comparison.
If it still doesn't improve try upping the precision to 4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the new source instead: https://rocket.rs/images/logo-small.svg

_data/simple-icons.json Outdated
{
"title": "Rocket",
"hex": "D33847",
"source": "https://github.com/simple-icons/simple-icons/pull/9492#issuecomment-1726472160"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an actual source from where the logo was picked up. Not a comment from the PR itself. Well if the author or someone had provided in the PR comments, that would have been acceptable.

Anyway, how about we use the logo-small.svg from their own website itself?

Suggested change
"source": "https://github.com/simple-icons/simple-icons/pull/9492#issuecomment-1726472160"
"source": "https://rocket.rs/"

@PeterShaggyNoble
Copy link
Member

@PratyushJayachandran, we need to use one of these SVGs as they have been provided to us by an official source. I opted for the one with square corners and without the trails as it would look better at our native size.

@PratyushJayachandran
Copy link
Member

@PratyushJayachandran, we need to use one of these SVGs as they have been provided to us by an official source. I opted for the one with square corners and without the trails as it would look better at our native size.

I compared the one posted by the creator and the one on the latest website. The alignment of the fit inside the box is different for both. In the interest of not dragging this further, I will apply changes so that you can review and merge.

The changes are based on SVG on the website header itself: https://rocket.rs/images/logo-small.svg

PratyushJayachandran
PratyushJayachandran approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches perfectly @IamRezaMousavi 🎉
Also thanks to @adamrusted and @PeterShaggyNoble for continued discussions and review!

@PratyushJayachandran PratyushJayachandran merged commit a0f0ad2 into simple-icons:develop Apr 3, 2024
4 checks passed
@simple-icons simple-icons bot mentioned this pull request Apr 7, 2024
Merged
simple-icons bot added a commit that referenced this pull request Apr 7, 2024
@simple-icons
Release 14 new icons and 2 updated icons (v11.12.0)
25c9d80 
# New Icons

- Anthropic (#10756) (@uncenter)
- bat (#10750) (@uncenter)
- BeatStars (#10767) (@PeterShaggyNoble)
- Copa Airlines (#10771) (@PeterShaggyNoble)
- Indian Super League (#10770) (@PeterShaggyNoble)
- Ktor (#10488) (@f-teruhisa)
- Malwarebytes (#10755) (@uncenter)
- Meizu (#10768) (@PeterShaggyNoble)
- Parrot Security (#10736) (@uncenter)
- Pixlr (#10777) (@PeterShaggyNoble)
- Qwik (#10378) (@Lissy93)
- Rocket (#9492) (@IamRezaMousavi)
- Stencil (#10769) (@PeterShaggyNoble)
- tldraw (#10703) (@thejoshyee)

# Updated Icons

- Font Awesome (#10759) (@patrik-csak)
- Simple Icons (#10765) (@LitoMore @PeterShaggyNoble)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratyushJayachandran PratyushJayachandran PratyushJayachandran approved these changes

@PeterShaggyNoble PeterShaggyNoble Awaiting requested review from PeterShaggyNoble

@adamrusted adamrusted Awaiting requested review from adamrusted

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Rocket icon
6 participants
@IamRezaMousavi @adamrusted @SergioBenitez @PeterShaggyNoble @PratyushJayachandran @mondeja