Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Framework icon #9819

Merged
merged 6 commits into from Nov 9, 2023
Merged

Add Framework icon #9819

merged 6 commits into from Nov 9, 2023

Conversation

Randomblock1
Copy link
Contributor

@Randomblock1 Randomblock1 commented Nov 6, 2023 •
edited

Issue: closes #9818

Similarweb rank: 29,186

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

They don't have brand guidelines but considering their whole thing they're probably OK with this.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Nov 6, 2023
PratyushJayachandran
PratyushJayachandran requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @Randomblock1, please review the suggestion

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/framework.svg Show resolved Hide resolved
Randomblock1 and others added 3 commits November 6, 2023 01:01
@Randomblock1 @PratyushJayachandran
Change Framework source to homepage
f0c8c00 
from about page

Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@Randomblock1
Fix Framework icon
2d1a3b8
@Randomblock1
Try to fix Framework icon?
85aabdf
@Randomblock1 @PratyushJayachandran
Actually fix Framework icon
12477ef 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@adamrusted adamrusted merged commit 193942e into simple-icons:develop Nov 9, 2023
3 checks passed
@Randomblock1 Randomblock1 deleted the framework branch November 10, 2023 08:54
@github-actions github-actions bot mentioned this pull request Nov 12, 2023
Merged
mondeja added a commit that referenced this pull request Nov 12, 2023
@mondeja
Release 3 new icons and 2 updated icons (v9.20.0)
910b08b 
# New Icons

- Apache Guacamole (#7674)
- Framework (#9819)
- YouTube Shorts (#9772)

# Updated Icons

- Angular (#9827)
- Boehringer Ingelheim (#9821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@PratyushJayachandran PratyushJayachandran PratyushJayachandran approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Framework
3 participants
@Randomblock1 @adamrusted @PratyushJayachandran