Skip to content

Commit

Permalink
chore: bump the version of the lockfile from v1 to v3 (#67)
Browse files Browse the repository at this point in the history
* bump lockfile-version from v1 to v3 

* bump Node.js runtime used in CI

Update the Node.js runtime used in CI jobs to 18. Correspondingly, this
will install a more recent version of npm, one with support for lockfile
version 3.

* install specific npm version for test jobs in CI

The test jobs need to run on various Node.js version, including some
older version. To ensure there's an npm version available that supports
lockfile v3, install a specific version of npm manually. Specifically
the lowest v8 release that supports it.

* bump lowest Node.js version tested in CI

While 12.20.0 and 14.13.1 are still supported by this package, some
dependencies minimum required version is 12.22.0 and 14.17.0 (resp.).

I don't expect these couple of minor bumps in Node.js version to cause a
compatibility issue in this project, so as a quick solution I'm bumping
the tested versions to match the lowest supported Node.js versions by
dependencies.
  • Loading branch information
ericcornelissen committed Oct 22, 2022
1 parent 2cceb34 commit 8353c59
Show file tree
Hide file tree
Showing 4 changed files with 2,965 additions and 1,634 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: actions/setup-node@v3
with:
cache: npm
node-version: 14
node-version: 18
- name: Install dependencies
run: npm ci
- name: Release
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: actions/setup-node@v3
with:
cache: npm
node-version: 14
node-version: 18
- name: Install dependencies
run: npm ci
- name: Lint
Expand All @@ -23,12 +23,13 @@ jobs:
name: Run tests
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
node-version:
- 12.20.0
- 14.13.1
- 12.22.0
- 14.17.0
- 16.0.0
- 18.0.0
- 12
Expand All @@ -49,6 +50,8 @@ jobs:
with:
cache: npm
node-version: ${{ matrix.node-version }}
- name: Install compatible npm version
run: npm install --global npm@8.1.2
- name: Install dependencies
run: npm ci
- name: Test
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
engine-strict=true
lockfile-version=3

0 comments on commit 8353c59

Please sign in to comment.