Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to create users from partner #1095

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Allow to create users from partner #1095

merged 4 commits into from
Jun 16, 2022

Conversation

cquintana92
Copy link
Collaborator

This PR performs the following changes:

  1. Adds a new optional parameter from_partner for the user creation. When this parameter is set, it will not send any notification to the user nor give the user any trial period.
  2. Set the parameter explicitly to False when logging in with Proton (the user has started the flow, so even if it's linked to a partner, it's not created by a partner)

@cquintana92 cquintana92 added the enhancement New feature or request label Jun 16, 2022
cquintana92 and others added 2 commits June 16, 2022 09:58
@cquintana92 @acasajus
Update tests/test_account_linking.py
1f34aa6 
Co-authored-by: Adrià Casajús <acasajus@users.noreply.github.com>
@cquintana92
Fix lint
0b0993d
@acasajus acasajus merged commit 5ee5e38 into master Jun 16, 2022
@acasajus acasajus deleted the feature/allow-to-create-users-from-partner branch June 16, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acasajus acasajus acasajus approved these changes

@nguyenkims nguyenkims Awaiting requested review from nguyenkims nguyenkims is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cquintana92 @acasajus