Send welcome mail to proton created users #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenkims
reviewed
Jun 17, 2022
| @@ -0,0 +1,36 @@ | |||
| {% extends "base.html" %} | |||
|
|
|||
| {% block content %} | |||
There was a problem hiding this comment.
We need to create a logo for Proton and SL here, let me ping the designer :)
There was a problem hiding this comment.
I think we can use this logo:
nguyenkims
approved these changes
Jun 17, 2022
|
Do we want to replace all other mail logos also or just this one?
…-------- Missatge Original --------
El 17 de juny de 2022, 8:35, Son Nguyen Kim va escriure:
@nguyenkims commented on this pull request.
LGTM, just left a comment.
---------------------------------------------------------------
In [templates/emails/com/onboarding/welcome-proton-user.txt.jinja2](#1099 (comment)):
> @@ -0,0 +1,36 @@
+{% extends "base.html" %}
+
+{% block content %}
We need to create a logo for Proton and SL here, let me ping the designer :)
—
Reply to this email directly, [view it on GitHub](#1099 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAFCCL5CP2UPSJ7VCVAAK2TVPQME3ANCNFSM5Y6XWDLQ).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@acasajus I already change the logo used in every email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users created directly will receive a special welcome email