Send welcome email when user created by login with proton #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenkims
reviewed
Jun 28, 2022
tests/models/test_user.py
Outdated
| @@ -8,6 +8,7 @@ def test_available_sl_domains(flask_client): | |||
| user = create_new_user() | |||
|
|
|||
| assert set(user.available_sl_domains()) == {"d1.test", "d2.test", "sl.local"} | |||
| assert user.created_by_partner is False | |||
There was a problem hiding this comment.
I think it's better to create a dedicated test for this field, this test is rather about SL domains.
There was a problem hiding this comment.
Moved it into a different test
| @@ -182,6 +182,9 @@ def process(self) -> LinkResult: | |||
| ) | |||
| Session.commit() | |||
|
|
|||
| if not new_user.created_by_partner: | |||
There was a problem hiding this comment.
do you know in what case new_user.created_by_partner can be True here?
There was a problem hiding this comment.
When called from the partner_api this flag will be True
nguyenkims
approved these changes
Jun 28, 2022
nguyenkims
deleted the
feature/send-welcome-email-when-user-created-by-login-with-proton
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.