Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete unused pages #115

Closed
wants to merge 5 commits into from
Closed

delete unused pages #115

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 4, 2024

Fix #114

@ghost
Copy link
Author

ghost commented Jan 4, 2024

I don’t really think we need this now after you updated footer and removed them all.

So… Maybe it is better to remove?

I think one page without other duplicate pages with small rephrasing will be more solid.

@nguyenkims what do you think?

@ghost ghost mentioned this pull request Jan 4, 2024
Closed
nguyenkims
nguyenkims reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@nguyenkims nguyenkims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there're still links to these pages so I think it's better to not delete them but rather not making them visible.

content/vs-apple-hide-my-email.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this page is still used I think

@ghost ghost closed this Jan 4, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete unused
1 participant
@nguyenkims