Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement Jenks #117

Closed
tmcw opened this issue Jul 27, 2015 · 5 comments
Closed

Reimplement Jenks #117

tmcw opened this issue Jul 27, 2015 · 5 comments

Comments

@tmcw
Copy link
Member

tmcw commented Jul 27, 2015

http://journal.r-project.org/archive/2011-2/RJournal_2011-2_Wang+Song.pdf

This approach to Jenks is simpler and faster than our existing approach. I'm planning on a clean-room implementation of the stated algorithm as a full replacement for v1.0.0.
This was referenced Jul 27, 2015
Closed
Closed
@stuaxo
Copy link

stuaxo commented Jul 28, 2015

Since you are doing a clean room implementation, it might be worth considering using numpy.

@tmcw
Copy link
Member Author

tmcw commented Jul 28, 2015

This is a JavaScript library, and numpy is in Python.

@stuaxo
Copy link

stuaxo commented Jul 28, 2015

Doh, sorry for the noise - have been looking at python libraries for the last few years :)

@tmcw
Copy link
Member Author

tmcw commented Jul 29, 2015

In JavaScript-land, a fast implementation might use ndarray, but the intent of simple-statistics is to be understandable first, so this implementation will start with normal ol' arrays.

@tmcw
Copy link
Member Author

tmcw commented Aug 10, 2015

Success! #118

@tmcw tmcw closed this as completed Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmcw @stuaxo