Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenks zero index? #25

Closed
stuaxo opened this issue Feb 18, 2013 · 3 comments
Closed

Jenks zero index? #25

stuaxo opened this issue Feb 18, 2013 · 3 comments

Comments

@stuaxo
Copy link

stuaxo commented Feb 18, 2013

Question - in the bits looping over the arrays I notice item 1 is set and all the loops go to len + 1.

Is this a side effect of fortran arrays starting at 1 ?

On a quick look, it looks like the zeroth elements are only accessed when the matrices are cleared.

http://developeronline.blogspot.co.uk/2008/04/why-array-index-should-start-from-0.html

This is probably just me misunderstanding the maths though :)

@tmcw
Copy link
Member

tmcw commented Feb 18, 2013

Good catch! I think you're right, I'll work on fixing this today.

@stuaxo
Copy link
Author

stuaxo commented Feb 18, 2013

Cool. I found this looking in the python one after your article. If it's right it should make the matrix loop code simpler.

@tmcw
Copy link
Member

tmcw commented Jul 27, 2015

Superseded by #117

@tmcw tmcw closed this as completed Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants