New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ckmeans #125

Merged

tmcw merged 2 commits into simple-statistics:master from llimllib:master

Aug 17, 2015

Contributor

llimllib commented Aug 16, 2015

the withinss was being calculated incorrectly; ((data_idx - 1) / data_idx) * squared_difference ignores the first data point (0/1) instead of multiplying it by 1/2
the mean was being calculated incorrectly. On the second data point, where data_idx is 1, first_cluster_mean was being set to the sum of the first two numbers instead of half that sum, and so on for each index. subtracting one from data_idx does the trick.

Related to, but does not complete, #124 .

llimllib added 2 commits

August 16, 2015 14:13


          fix mean and withinss calculations

dad0223


          correct test values

95abb23

Member

tmcw commented Aug 17, 2015

🙌 awesome!

tmcw added a commit that referenced this pull request


          Merge pull request #125 from llimllib/master

b938e56

Fix ckmeans

tmcw merged commit b938e56 into simple-statistics:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment