Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding volume control support for sounds and sound mixer #113

Merged
merged 2 commits into from Jan 5, 2020

Conversation

@tlrasor
Copy link
Contributor

tlrasor commented Aug 31, 2019

Adding support for volume control in response to Ruby2d issue: ruby2d/ruby2d#115

Implemented two ways to handle this, S2D_GetSoundVolume and S2D_SetSoundVolume set the volume mix for a particular sound. Additionally, S2D_GetSoundMixVolume and S2D_SetSoundMixVolume set the volume for the whole mixer. For simplicity's sake, all channels are set to the same volume value.

@blacktm

This comment has been minimized.

Copy link
Member

blacktm commented Jan 5, 2020

This is perfect, thanks @tlrasor! (And sorry it so long to review and merge. 😬)

@blacktm blacktm merged commit cd25b01 into simple2d:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.