Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install instructions are missing when adding a website #456

Closed
adriaandotcom opened this issue Oct 20, 2020 · 4 comments
Closed

Install instructions are missing when adding a website #456

adriaandotcom opened this issue Oct 20, 2020 · 4 comments
Assignees
@jibsaramnim
Labels
bug Something isn't working customer request Tasks created by customers via our website
Milestone
Important

Comments

@adriaandotcom
Copy link
Contributor

When clicking from:

Screenshot

You do not get install instructions but an empty dashboard page:

Screenshot
@adriaandotcom adriaandotcom added bug Something isn't working customer request Tasks created by customers via our website labels Oct 20, 2020
@adriaandotcom adriaandotcom added this to the Week 43 milestone Oct 20, 2020
@jibsaramnim
Copy link

This should be implemented now, pending deploy!

@adriaandotcom
Copy link
Contributor Author

@hellodeibu One thing though. If it has visitsCount > 0 we assume it hasScript as well. Sometimes hasScript is not detected but if visits show up, we know it is there. Is this the case in your code as well?

@jibsaramnim
Copy link

Yes I think that's done by looking solely at totalVisits > 0 here, which I believe is how it worked originally too.

@adriaandotcom
Copy link
Contributor Author

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jibsaramnim jibsaramnim

Labels
bug Something isn't working customer request Tasks created by customers via our website
Projects
None yet
Milestone
Important
Development

No branches or pull requests
2 participants
@jibsaramnim @adriaandotcom