Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes MathKeyboard and adds some design improvements #49

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

tomkuschka
Copy link
Contributor

Description

Exposes MathKeyboard so it can be used independently from MathField. Also adds a hover effect on MathKeyboard for better web support and some padding.

Checklist

Remove If [...] items that do not apply to your PR.

  • I have made myself familiar with the CaTeX
    contributing guide.
  • I added a PR description.
  • I linked all related issues and PRs I could find (no links if there are none).
  • If this PR changes anything about the main math_keyboard or example package
    (also README etc.), I created an entry in CHANGELOG.md (## UPCOMING RELEASE if the change
    on its own is not worth an update).
  • If this PR includes a notable change in the math_keyboard package, I updated the version
    according to Dart's semantic versioning.
  • If there is new functionality in code, I added tests covering all my additions.
  • All required checks pass.

@tomkuschka tomkuschka requested a review from edhom as a code owner March 28, 2023 07:45
@vmalyi
Copy link

vmalyi commented Mar 28, 2023

@tomkuschka, what about all those failed checks?

@tomkuschka
Copy link
Contributor Author

@vmalyi They also failed on previous PRs. I think we can ignore them

@tomkuschka tomkuschka requested a review from edhom March 29, 2023 12:14
edhom
edhom previously approved these changes Mar 29, 2023
Copy link
Member

@edhom edhom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomkuschka tomkuschka merged commit d12744b into main Mar 29, 2023
@tomkuschka tomkuschka deleted the task/design-improvement branch March 29, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants