Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close keyboard on hardware back press #56

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Close keyboard on hardware back press #56

merged 4 commits into from
Jul 6, 2023

Conversation

millerovv
Copy link
Contributor

@millerovv millerovv commented Jul 4, 2023

Description

  • Aligns behavior of the keyboard with native Android keyboard and closes it when user pressed hardware "back".
  • Adds Android project to the math_keyboard_demo.
  • Main changes are in math_field.dart.
de.mov

Related issues & PRs

https://simpleclub.atlassian.net/browse/SC-10050

Checklist

Remove If [...] items that do not apply to your PR.

  • I have made myself familiar with the CaTeX
    contributing guide.
  • I added a PR description.
  • I linked all related issues and PRs I could find (no links if there are none).
  • If this PR changes anything about the main math_keyboard or example package
    (also README etc.), I created an entry in CHANGELOG.md (## UPCOMING RELEASE if the change
    on its own is not worth an update).
  • If this PR includes a notable change in the math_keyboard package, I updated the version
    according to Dart's semantic versioning.
  • If there is new functionality in code, I added tests covering all my additions.
  • All required checks pass.

@millerovv millerovv requested a review from edhom as a code owner July 4, 2023 10:54
@millerovv millerovv requested a review from vmalyi July 4, 2023 10:54
@millerovv millerovv added the bug Something isn't working label Jul 4, 2023
@tomkuschka
Copy link
Contributor

@millerovv The dismiss animation is not triggered when I hardware back is pressed ☹️ Since the animation happens on when the return key is pressed, I think we should also play it here

@millerovv
Copy link
Contributor Author

@tomkuschka The closing animation is now working:

2023-07-05.10.52.45.mov

@millerovv millerovv requested a review from tomkuschka July 5, 2023 08:54
@codecov-commenter
Copy link

Codecov Report

Merging #56 (7180251) into main (f586c6b) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   27.44%   27.11%   -0.34%     
==========================================
  Files          11       11              
  Lines        1133     1147      +14     
==========================================
  Hits          311      311              
- Misses        822      836      +14     
Flag Coverage Δ
math_keyboard 27.11% <0.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
math_keyboard/lib/src/widgets/math_field.dart 0.00% <0.00%> (ø)

@tomkuschka tomkuschka self-assigned this Jul 6, 2023
Copy link
Member

@edhom edhom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@millerovv millerovv merged commit 80cbf1a into main Jul 6, 2023
12 checks passed
@millerovv millerovv deleted the keyboard-hide branch July 6, 2023 09:50
@millerovv millerovv mentioned this pull request Jul 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

4 participants