Show Branch Coverage in stdout if enabled. #117
Conversation
|
This is basically the same pull request as #103, except it is a larger change to the output format. Personally, I'm fine with either pull request. Anything that gets the branch coverage output to stdout would be an improvement over the current behavior, which forces users to check the coverage html file to find the branch coverage. |
|
Agreed. I didn't see that PR before this, otherwise, I would have bumped it up. Personally, I prefer the organized layout of this PR with Line Coverage and Branch Coverage on separate lines. Not sure about #103, but we've been using this PR/fork in production for a few months now without any issue. |
|
Any chance we can get this merged in? We've been using it in our CI for about a year with great results. To reiterate, I think it's a cleaner solution than the other PR that tries to accomplish the same thing. Thanks. |
Prior to this only Line Coverage is shown in the stdout. Branch coverage is equally important, when it is enabled, so it should be shown alongside it to ensure adequate coverage of the code base. Now it shows in a clean format, including covered branches, total branches and percent of covered branches. Something like this: ``` Coverage report generated for (1/10), (10/10), (2/10), (3/10), (4/10), (5/10), (6/10), (7/10), (8/10), (9/10) to /Users/me/Development/cntral/coverage. Line Coverage: 7554 / 12927 (58.44%) Branch Coverage: 1868 / 3704 (50.43%) ``` When branch coverage is not enabled it simply omits that line, so it appears like this: ``` Coverage report generated for (1/10), (10/10), (2/10), (3/10), (4/10), (5/10), (6/10), (7/10), (8/10), (9/10) to /Users/me/Development/cntral/coverage. Line Coverage: 7554 / 12927 (58.44%) ```
And then covered and total counts in brackets afterwards. Percentage is most critical at a quick glance.
|
@joshuapinter Just merged #103 which is very similar to this patch but without the "percentage first" change, because I'm trying not to make any design change which I have never done for this project. Please make another pull request for the second commit which is a separate topic from branch coverage, and get approval from other members. Also, it seems that Thank you for your patch and your patience! |
|
@amatsuda No worries and thank you for merging that in. We can start using the main branch again. I'll review the code to check for the issue you pointed out and do the format change as a separate PR (if I think it's still worthwhile). Thanks again. 🙏 |
Prior to this only Line Coverage is shown in the stdout.
Branch coverage is equally important, when it is enabled, so it should be shown alongside it to ensure adequate coverage of the code base.
Now it shows in a clean format, including covered branches, total branches and percent of covered branches. I also moved the percentages first and the coverage and total lines/branches afterwards in brackets. So it looks something like this:
When branch coverage is not enabled it simply omits that line, so it appears like this: