Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS/CSS dependencies for better CSP compatibility #51

Closed
wants to merge 6 commits into from
Closed

Conversation

koenpunt
Copy link
Contributor

Currently to allow the coverage page to be working correctly it requires a very loose Content-Security-Policy, e.g.:

script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline';

With the changes in this PR this can be updated to a more restricted:

default-src 'none'; script-src 'self'; img-src 'self'; style-src 'self';

Fixes #50

@koenpunt
Copy link
Contributor Author

Found out that the sorting in the datatable isn't currently working as expected, but that should be trivial to fix.

@PragTob
Copy link
Collaborator

PragTob commented Feb 8, 2020

👋

Hi there, thanks for this 💚

I know it's been way too long, but well I first spent my time on "core" simplecov and kinda worked my way here. Sorry for the delay.

I'll see how I'll handle this. I'm not sure if a merge will be the best way, might start over and use your implementation as a guide. But yes this needs to be tackled

Cheers,
Tobi

@PragTob
Copy link
Collaborator

PragTob commented Feb 12, 2020

Replaced by #89

@PragTob PragTob closed this Feb 12, 2020
@koenpunt koenpunt deleted the csp branch May 27, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Security-Policy (CSP) violations
2 participants