Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI debugging #1086

Merged
merged 3 commits into from
Apr 15, 2024
Merged

CI debugging #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78df6e6
trigger ci
PragTob Apr 15, 2024
daea5b2
Deactivate warnings test on JRuby due to https://github.com/jruby/jru…
PragTob Apr 15, 2024
3a4a7fd
gee rubocop I just wanted to make a name collision less likely
PragTob Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ PLATFORMS
java
ruby
universal-java-1.8
universal-java-11

DEPENDENCIES
activesupport (~> 6.1)
Expand Down
10 changes: 9 additions & 1 deletion features/support/env.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,15 @@

Before("@process_fork") do
# Process.fork is NotImplementedError in jruby
skip_this_scenario if defined?(RUBY_ENGINE) && RUBY_ENGINE == "jruby"
skip_this_scenario if jruby?
end

Before("@no_jruby") do
skip_this_scenario if jruby?
end

def jruby?
defined?(RUBY_ENGINE) && RUBY_ENGINE == "jruby"
end

Aruba.configure do |config|
Expand Down
3 changes: 2 additions & 1 deletion features/warnings.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@rspec
# deactivating on JRuby due to https://github.com/jruby/jruby/issues/8200
@rspec @no_jruby
Feature:

Running SimpleCov with verbosity enabled does not yield warnings.
Expand Down