Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gems & fix new rubocop offenses #1098

Merged
merged 1 commit into from
Jun 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ GEM
regexp_parser (>= 1.5, < 3.0)
xpath (~> 3.2)
coderay (1.1.3)
concurrent-ruby (1.2.3)
concurrent-ruby (1.3.3)
contracts (0.17)
cucumber (9.2.0)
builder (~> 3.2)
Expand Down Expand Up @@ -79,22 +79,22 @@ GEM
ffi (1.16.3-java)
i18n (1.14.4)
concurrent-ruby (~> 1.0)
json (2.7.1)
json (2.7.1-java)
json (2.7.2)
json (2.7.2-java)
language_server-protocol (3.17.0.3)
matrix (0.4.2)
method_source (1.0.0)
mini_mime (1.1.5)
mini_portile2 (2.8.6)
minitest (5.22.3)
mini_portile2 (2.8.7)
minitest (5.24.0)
multi_test (1.1.0)
nokogiri (1.16.4)
nokogiri (1.16.6)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.16.4-java)
nokogiri (1.16.6-java)
racc (~> 1.4)
parallel (1.24.0)
parser (3.2.2.4)
parallel (1.25.1)
parser (3.3.3.0)
ast (~> 2.4.1)
racc
power_assert (2.0.3)
Expand All @@ -106,18 +106,19 @@ GEM
method_source (~> 1.0)
spoon (~> 0.0)
public_suffix (5.0.5)
racc (1.7.3)
racc (1.7.3-java)
racc (1.8.0)
racc (1.8.0-java)
rack (3.0.10)
rack-test (2.1.0)
rack (>= 1.3)
rackup (2.1.0)
rack (>= 3)
webrick (~> 1.8)
rainbow (3.1.1)
rake (13.1.0)
regexp_parser (2.9.0)
rexml (3.2.6)
rake (13.2.1)
regexp_parser (2.9.2)
rexml (3.3.0)
strscan
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
Expand All @@ -131,24 +132,26 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
rubocop (1.59.0)
rubocop (1.64.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.4)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.30.0, < 2.0)
rubocop-ast (>= 1.31.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.30.0)
parser (>= 3.2.1.0)
rubocop-ast (1.31.3)
parser (>= 3.3.1.0)
ruby-progressbar (1.13.0)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)
spoon (0.0.6)
ffi
strscan (3.1.0)
strscan (3.1.0-java)
sys-uname (1.2.3)
ffi (~> 1.1)
test-unit (3.6.1)
Expand Down
16 changes: 8 additions & 8 deletions spec/configuration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -134,29 +134,29 @@
end

it "sets the right coverage value when called with `:line`" do
config.public_send(:refuse_coverage_drop, :line)
config.refuse_coverage_drop(:line)

expect(config.public_send(:maximum_coverage_drop)).to eq line: 0
expect(config.maximum_coverage_drop).to eq line: 0
end

it "sets the right coverage value when called with `:branch`" do
config.enable_coverage :branch
config.public_send(:refuse_coverage_drop, :branch)
config.refuse_coverage_drop(:branch)

expect(config.public_send(:maximum_coverage_drop)).to eq branch: 0
expect(config.maximum_coverage_drop).to eq branch: 0
end

it "sets the right coverage value when called with `:line` and `:branch`" do
config.enable_coverage :branch
config.public_send(:refuse_coverage_drop, :line, :branch)
config.refuse_coverage_drop(:line, :branch)

expect(config.public_send(:maximum_coverage_drop)).to eq line: 0, branch: 0
expect(config.maximum_coverage_drop).to eq line: 0, branch: 0
end

it "sets the right coverage value when called with no args" do
config.public_send(:refuse_coverage_drop)
config.refuse_coverage_drop

expect(config.public_send(:maximum_coverage_drop)).to eq line: 0
expect(config.maximum_coverage_drop).to eq line: 0
end
end

Expand Down