Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes order dependencies in unit tests #376

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/test_filters.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,14 @@ class TestFilters < Minitest::Test

context "with no filters set up and a basic source file in an array" do
setup do
SimpleCov.filters = []
@prev_filters, SimpleCov.filters = SimpleCov.filters, []
@files = [SimpleCov::SourceFile.new(source_fixture('sample.rb'), [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil])]
end

teardown do
SimpleCov.filters = @prev_filters
end

should "return 0 items after executing SimpleCov.filtered on files when using a 'sample' string filter" do
SimpleCov.add_filter "sample"
assert_equal 0, SimpleCov.filtered(@files).count
Expand Down
13 changes: 10 additions & 3 deletions test/test_result.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,21 @@
class TestResult < Minitest::Test
context "With a (mocked) Coverage.result" do
setup do
SimpleCov.filters = []
SimpleCov.groups = {}
SimpleCov.formatter = nil
@prev_filters, SimpleCov.filters = SimpleCov.filters, []
@prev_groups, SimpleCov.groups = SimpleCov.groups, {}
@prev_formatter, SimpleCov.formatter = SimpleCov.formatter, nil

@original_result = {source_fixture('sample.rb') => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil],
source_fixture('app/models/user.rb') => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
source_fixture('app/controllers/sample_controller.rb') => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil]}
end

teardown do
SimpleCov.filters = @prev_filters
SimpleCov.groups = @prev_groups
SimpleCov.formatter = @prev_formatter
end

context "a simple cov result initialized from that" do
setup { @result = SimpleCov::Result.new(@original_result) }

Expand Down