Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memoize SimpleCov::Configuration#coverage_path #453

Merged
merged 1 commit into from
Jan 26, 2016
Merged

memoize SimpleCov::Configuration#coverage_path #453

merged 1 commit into from
Jan 26, 2016

Conversation

paddor
Copy link
Contributor

@paddor paddor commented Jan 26, 2016

This is to avoid calling FileUtils.mkdir_p like 50 times, like visible here when $DEBUG = true:

[...]
Finished in 0.20738 seconds (files took 0.69467 seconds to load)
42 examples, 1 failure, 1 pending

Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
[Coveralls] Outside the CI environment, not sending data.
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage
Exception `Errno::EEXIST' at /Users/paddor/.rubies/ruby-2.3.0/lib/ruby/2.3.0/fileutils.rb:253 - File exists @ dir_s_mkdir - /Users/paddor/src/ruby/cztop/coverage

colszowka added a commit that referenced this pull request Jan 26, 2016
@colszowka
Merge pull request #453 from paddor/master
619e522 
memoize SimpleCov::Configuration#coverage_path
@colszowka colszowka merged commit 619e522 into simplecov-ruby:master Jan 26, 2016
@colszowka
Copy link
Collaborator

👍 Thanks!

colszowka added a commit that referenced this pull request Jan 26, 2016
@colszowka
Update changelog for #453
f36e523
@paddor
Copy link
Contributor Author

paddor commented Jan 26, 2016

Welcome!

craiglittle pushed a commit to craiglittle/simplecov that referenced this pull request Feb 13, 2016
@colszowka @craiglittle
Update changelog for simplecov-ruby#453
1cbd5f5
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Feb 17, 2016
Update ruby-simplecov to 0.11.2.
338f9fb 
## Enhancements

## Bugfixes

0.11.2 2016-02-03 ([changes](simplecov-ruby/simplecov@v0.11.1...v0.11.2))
=================

## Enhancements

* Do not globally pollute Array and Hash with `merge_resultset` utility methods. See [#449](simplecov-ruby/simplecov#449) (thanks @amatsuda)
* Do not `mkdir_p` the `coverage_path` on every access of the method (See [#453](simplecov-ruby/simplecov#453) (thanks @paddor)
* Fixes a Ruby warning related to the `track_files` configuration. See [#447](simplecov-ruby/simplecov#447) (thanks @craiglittle)
* Add a group for background jobs to default Rails profile. See [#442](simplecov-ruby/simplecov#442) (thanks @stve)

## Bugfixes

* Fix root_filter evaluates SimpleCov.root before initialization. See [#437](simplecov-ruby/simplecov#437) (thanks @tmtm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paddor @colszowka