Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh our CI configuration #895

Merged
merged 6 commits into from
Jun 21, 2020
Merged

Refresh our CI configuration #895

merged 6 commits into from
Jun 21, 2020

Conversation

deivid-rodriguez
Copy link
Collaborator

No description provided.

These don't need updates on every jruby version bump.
@PragTob
Copy link
Collaborator

PragTob commented Jun 20, 2020

👋

  • thanks + 💚

JRuby failures... I was hoping I could help right now but I gotta run and likely won't be back all day. Might be able to take a look tomorrow. I'll try and trigger a build on the main branch.

     # ./spec/return_codes_spec.rb:10:in `block in <main>'

  2) return codes inside fixtures/frameworks when running testunit_bad.rb behaves like bad tests with default configuration prints a message to STDERR
     Failure/Error: expect(@stderr).to eq "SimpleCov failed with exit #{@status.exitstatus}\n"

       expected: "SimpleCov failed with exit 1\n"
            got: ""

       (compared using ==)

       Diff:
       @@ -1,2 +1 @@
       -SimpleCov failed with exit 1
     Shared Example Group: "bad tests" called from ./spec/return_codes_spec.rb:66
     # ./spec/return_codes_spec.rb:37:in `block in <main>'
     # ./spec/return_codes_spec.rb:12:in `block in <main>'
     # ./spec/return_codes_spec.rb:10:in `block in <main>'

Finished in 2 minutes 1.7 seconds (files took 1.99 seconds to load)
335 examples, 2 failures

Failed examples:

rspec './spec/return_codes_spec.rb[1:1:4:1:1:2]' # return codes inside fixtures/frameworks when running rspec_bad.rb behaves like bad tests with default configuration prints a message to STDERR

@deivid-rodriguez
Copy link
Collaborator Author

I'm confused, since it passes for me locally 😬

@deivid-rodriguez
Copy link
Collaborator Author

The base OS upgrades and switching to the official ruby action in the unstable workflow were messing things up, so I reverted those changes.

Copy link
Collaborator

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton 💚

WhatsApp Image 2020-04-17 at 11 30 40

@PragTob PragTob merged commit 311d9db into master Jun 21, 2020
@PragTob PragTob deleted the bump_ci branch June 21, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants