This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Add a replacement in cleanURL #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @baptistejamin! Thank you for your PR that should fix this issue. I'd like to know where did you encountered that character? |
|
I don't remember exactly as it happened back in June. We format thousands of pages everyday and we log every issue we had. This patch fixed several things with URLs. |
|
Okay, as far as I see the #439 is not the only case. Therefore this fix could make sense. Please update your branch and I'll merge the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is fixing an unimplemented special char case in URLs.