New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to home screen and bs history #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to include French and Spanish language options in app
Release 0.6
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
…ster-json--staging_hi_IN Translate '/translations/master.json' in 'hi_IN'
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
English string update
translation completed for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed for the source file '/translations/master.json' on the 'es' language.
translation completed updated for the source file '/translations/master.json' on the 'es' language.
Removed unused or duplicate strings
translation completed for the source file '/translations/master.json' on the 'es' language.
translation completed for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed updated for the source file '/translations/master.json' on the 'hi_IN' language.
translation completed for the source file '/translations/master.json' on the 'fr' language.
translation completed updated for the source file '/translations/master.json' on the 'fr' language.
translation completed updated for the source file '/translations/master.json' on the 'fr' language.
translation completed updated for the source file '/translations/master.json' on the 'fr' language.
…ster-json--staging_fr Translate '/translations/master.json' in 'fr'
…ster-json--staging_hi_IN Translate '/translations/master.json' in 'hi_IN'
…merge Connect an offline account with your BP Passport via Settings
Adjust home card margins
Merge branch 'iteration-7' into text-changes
@kenjam97 - you missed the bit about making the add bp and add bs screens into modals. I did this on your branch here - do checkout the changes I made to Navigation.tsx to implement this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes some of the strings used in the home screen and the blood sugar history screen.
It also adds the page title for blood sugar history to the flat list correctly.
Tickets:
https://trello.com/c/HCenCUN3/173-bug-all-bp-blood-sugar-all-bp-should-be-all-bps-all-bs-should-be-all-blood-sugars
https://trello.com/c/C4ef9Mex/175-bug-home-screen-add-blood-sugar-button-label-should-be-add-in-home-view-text-doesnt-fit-in-button
https://trello.com/c/nVvA4ptK/178-bug-add-bp-blood-sugar-title-should-be-add-bp-add-blood-sugar-and-view-should-be-a-modal-not-segue
https://trello.com/c/gcnmdjgd/172-bug-all-bp-blood-sugar-title-should-scroll-with-rows
https://trello.com/c/hgTxXsz8/153-bug-all-bps-header-in-designs-says-all-bps-currently-on-app-is-bp-history