New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User login fails when multiple users have the same phone number #60

Closed

timcheadle opened this issue Jul 2, 2018 · 1 comment

Contributor

timcheadle commented Jul 2, 2018

We perform User login using the following code:

# app/controllers/api/v1/logins_controller.rb
user = User.find_by(phone_number: login_params[:phone_number])

This fails when multiple users have the same phone number.

Contributor

govindkrjoshi commented Sep 24, 2018

Phone number should be unique for a user. This should be fixed now since at login, we do a phone number lookup for the patient.

govindkrjoshi closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment