Make cron respect timezone #1121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitallis
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
✨
We'll have to stick this env var in https://github.com/simpledotorg/deployment I presume?
|
The env var is already populated in all environments, and the cron jobs will default to "Asia/Kolkata" if missing. For Ethiopia, yes we are adding |
…le-server into ethiopia-config-tweaks
This reverts commit 95a03fc.
harimohanraj89
changed the title
kitallis
approved these changes
Jul 1, 2020
|
Closing in favor of #1125 |
harimohanraj89
added a commit
that referenced
this pull request
Jul 1, 2020
**Story card:** https://www.pivotaltracker.com/story/show/173219451 ### This PR is identical to #1121 , but the sempahore integration on #1121 is borked 😓 ## Because Timezone for cron jobs needs to be configurable, and cannot be read from `Rails.application.config.countries`, since the app environment is not loaded here. ## This addresses Loads the Rails env and sets the cron timezone based on the country config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story card: https://www.pivotaltracker.com/story/show/173219451
Because
Timezone for cron jobs needs to be configurable, and cannot be read from
Rails.application.config.countries, since the app environment is not loaded here.This addresses
Loads the Rails env and sets the cron timezone based on the country config.