Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only see sensible depths of the access tree #1264

Closed
wants to merge 133 commits into from
Closed

Only see sensible depths of the access tree #1264

wants to merge 133 commits into from

Conversation

kitallis
Copy link
Contributor

Story card:

Because

Enter the reason for raising this PR...

This addresses

Enter the details of what all this covers...

kitallis and others added 30 commits July 28, 2020 13:50
@kitallis
Add the access model with some basic specs
d4ba4b6
@kitallis
WIP
798b3c3
@kitallis
Rename resource to scope
1d3ef0d
@kitallis
Add a factory template for access
9839df3
@kitallis
Merge branch 'permissions-data-model' into permissions-access-methods
5338be1
@kitallis
Add the three basic scoping methods
80bee5c
@kitallis
Add more thorough validation specs
2b4b04b
@kitallis
Merge branch 'permissions-data-model' into permissions-access-methods
545a0bc
@kitallis
Rename ALLOWED_SCOPES to ALLOWED_RESOURCES
03ba593
@kitallis
Instead of inclusion:nil, use absence
d6fdccd
@kitallis
Change mode to role
d127930
@kitallis
Merge branch 'permissions-data-model' into permissions-access-methods
9406e31
@kitallis
mode to role in factories
c6079ec
@kitallis
Merge branch 'permissions-data-model' into permissions-access-methods
f21c824
@kitallis
Access.organizations specs
34ba637
@kitallis
Access.organizations specs (pass 2)
8fe631a
@vkrmis
Rename mode to role in breaking spec
69bc235
@vkrmis
Merge branch 'permissions-data-model' into permissions-access-methods
8f35424
@vkrmis
Add a .can? method on User
224f70a
@vkrmis
Delegate user.can? to access model
1e7b17e
@kitallis
Refactor the can? method for clarity and purpose
7ba5f87
@kitallis
Add uniqueness constraint on user<>role
fdd518e
@kitallis
Add a validation for user to only have 1 role
691d0cb
@kitallis
Fix specs
4e5491b
@kitallis
Specs to validate that user should only ever have one role thru Access
7abeb1c
@kitallis
Minor aesthetic
2482ea3
@kitallis
Add delegates to User for Access
4419d89
@kitallis
Add specs to scope against FacilityGroups
a5f6210
@kitallis
Specs for Access.can?
344f119
@kitallis
Merge branch 'master' into permissions-access-methods
8900c5a
kitallis and others added 19 commits August 26, 2020 10:15
@kitallis
Add parallel methods for the EmailAuth -> Invite flow
5014047
@danySam
Remove yellow background from leaf facility item nodes
bc0dde2
@danySam
Fix dropdown arrow not rotating
1ff6e9b 
Caused by click listener not aware of change when triggered by child
@kitallis
Add comments about the parallel methods
5cac8b4
@kitallis
Thanks standard
942fbcb
@kitallis
Merge branch 'master' into permissions-ui
c1c3846
@kitallis
The Add New Admin button is flipper flag aware
663be2c
@kitallis
Pull the parallel dark launch methods back up into standard controllers
fcc3ca7
@kitallis
Remove the form submission checkbox hack and Just Use HTML™
b12ec79
@kitallis
Allow editing an existing admin
5d4010e
@danySam
Minor JS cleanup
9f294a3
@danySam
Move dropdown arrow to the beginning of the checkbox item
5bbb361
@danySam
Fix dropdown toggle for collapse/expand
2d447c1
@kitallis
Remove extraneous JS
75879e4
@kitallis
Make the access tree more efficient
e075a59 
This is done in 2 ways:

- memoize critical accessible_methods
- lookup the tree using a hash instead of multiple can? methods
@kitallis
Delegate access_tree straight off the User
0809b7b
@kitallis
Make UserAccess#grant_access more efficient
d188b7a 
- bulk import
- check from memory instead of DB
@kitallis
Merge branch 'make-grant-access-more-efficient' into permissions-edit-ui
b3db69e
@kitallis
Add selective tree depth based on your access tree
2c522e7
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1264 August 31, 2020 05:16 Inactive
@kitallis kitallis changed the title Permissions access tree selective depth Only see sensible depths of the access tree based based on current access Aug 31, 2020
@kitallis kitallis changed the title Only see sensible depths of the access tree based based on current access Only see sensible depths of the access tree Aug 31, 2020
@kitallis kitallis added the simple-permissions new and improved simpler permissions system for the year 2020 label Aug 31, 2020
@kitallis kitallis mentioned this pull request Aug 31, 2020
Closed
8 tasks
@danySam
Simplify logic to collapse checkbox tree
10428cd 
Made the JS add/remove "collapsed" class only from the top level
element. Rest of the magic is moved to the CSS
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1264 September 1, 2020 11:11 Inactive
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1264 September 2, 2020 06:14 Inactive
@kitallis kitallis closed this Sep 2, 2020
@rsanheim rsanheim deleted the permissions-access-tree-selective-depth branch November 18, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
simple-permissions new and improved simpler permissions system for the year 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kitallis @harimohanraj89 @vkrmis @danySam