Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Docker configs for issue #2108 #2739

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

benryder1988
Copy link
Contributor

Story card: #2108

Because

As mentioned in the issue, the Dockerfile was out out date with the required Ruby version, and when the Ruby version was updated there was a Redis error.

Issue details: #2108

This addresses

The Ruby version was updated in the Dockerfile, and the Redis bug fixed by updating the Docker Compose config. The README was updated with details on removing the volumes used by docker compose, and how to test with the Android App.

Test instructions

  • Run the server with 'docker compose up'
  • Capture the ngrok url from the logs
  • Configure the Android App to use the ngrok URL
  • Build and test the app

@rsanheim
Copy link
Contributor

rsanheim commented Jul 21, 2021

Thanks for this! I verified it all works w/ my docker setup here.

@rsanheim rsanheim merged commit 1f208fe into simpledotorg:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants