Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer Cohort Report Download Links #931

Merged
merged 5 commits into from May 6, 2020

Conversation

harimohanraj89
Copy link
Contributor

@harimohanraj89 harimohanraj89 commented May 5, 2020

Story card: https://www.pivotaltracker.com/story/show/172668133

Because

Currently, the cohort report download link is either monthly or quarterly based on the current web view. This is confusing.

This addresses

Adding explicit "Quarterly Cohort Report" and "Monthly Cohort Report" download links, regardless of webview. This addresses the cohort download links on both district and facility pages.

Additionally, it makes a few small tweaks based on @dburka's wisdom:

  • Add "Monthly"/"Quarterly" to filename and report title
  • Patients registered -> Patients in cohort
  • Patients defaulted -> Patients didn't attend

Screenshots

Before

Screenshot 2020-05-05 at 1 58 08 PM

After

Screenshot 2020-05-05 at 1 57 50 PM

@harimohanraj89 harimohanraj89 temporarily deployed to simple-clearer-cohort-d-ozdtn5 May 5, 2020 08:32 Inactive
@harimohanraj89 harimohanraj89 temporarily deployed to simple-clearer-cohort-d-ozdtn5 May 5, 2020 10:52 Inactive
Copy link
Contributor

@timcheadle timcheadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if "Patients in cohort" will be confusing, we'll see.

@kitallis kitallis temporarily deployed to simple-clearer-cohort-d-ozdtn5 May 6, 2020 07:05 Inactive
@harimohanraj89 harimohanraj89 merged commit 4d04b24 into master May 6, 2020
@harimohanraj89 harimohanraj89 deleted the clearer-cohort-download-links branch May 6, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants