Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ualpha and Ubeta to FOCMotor #326

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

Candas1
Copy link
Collaborator

@Candas1 Candas1 commented Oct 23, 2023

This is just about moving Ualpha and Ubeta to FOCMotor so it's available to the flux observer sensor.

@Candas1
Copy link
Collaborator Author

Candas1 commented Oct 23, 2023

I just forgot it's also used here
I keep forgetting about stepper motors.
It could be removed from StepperMotor.h then.

@runger1101001
Copy link
Member

Hmmm - it looks here like a bunch of the AVR checks are failing. I think we have to look into why before we can merge it...

@Candas1
Copy link
Collaborator Author

Candas1 commented Oct 30, 2023

Hmmm - it looks here like a bunch of the AVR checks are failing. I think we have to look into why before we can merge it...

Welcome back and thanks for merging the PRs.
As I mentioned I forgot to update StepperMotor.h, but I am not sure if it's the reason compilation fails, I will investigate.

I am trying to keep each PR minimal, I hope it's ok.

@Candas1
Copy link
Collaborator Author

Candas1 commented Oct 30, 2023

I tried removing Ualpha and Ubeta from StepperMotor.h also and initializing it in FOCMotor.cpp, but no luck.
That looks like a very random issue.

I am cursed:
arduino/ArduinoCore-avr#341

@runger1101001
Copy link
Member

Weird, right? I haven't really figured out what it is...

But in the meantime I have found and fixed the various esp32 compile problems, of which there were several. None of them had anything to do with your changes, as expected.

@runger1101001
Copy link
Member

If you merge over my recent changes I think that will fix the ESP32 side of things, at least

Merge new dev changes
@Candas1
Copy link
Collaborator Author

Candas1 commented Oct 31, 2023

Merges all the last dev changes fixed ESP32 compilation as you said, but avr is still failing.
So this issue is not so random as I thought.

@runger1101001
Copy link
Member

@askuric askuric changed the base branch from dev to master April 19, 2024 07:10
@askuric askuric changed the base branch from master to dev April 19, 2024 07:10
@askuric askuric changed the base branch from dev to master April 19, 2024 17:38
@askuric askuric changed the base branch from master to dev April 19, 2024 17:38
@askuric
Copy link
Member

askuric commented Apr 19, 2024

I think the avr issue is fixed so I'm merging this. :D

@askuric askuric merged commit 1425dff into simplefoc:dev Apr 19, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants