Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in SCIM naming. #22

Closed
bzuidgeest opened this issue Mar 5, 2020 · 8 comments
Closed

typo in SCIM naming. #22

bzuidgeest opened this issue Mar 5, 2020 · 8 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@bzuidgeest
Copy link

Line 20 in StandardSCIMRepresentationAttributes has a value of "descriptions" I believe this should be "description" without an "s" add the end. Please correct me if I am wrong.

Also The description on the schema (schemas endpoint) takes the name from the schemabuilder and not the provided description. The resourceType endpoint does do this properly.

{

"id": "urn:ietf:params:scim:schemas:extension:nleducation:1.0:eduuser",
"name": "eduUser",
"descriptions": "eduUser",
"attributes": [
{
"name": "eckId",
"type": "string",
"multiValued": false,
"descriptions": "The unique identification of the user for digital content",
"required": true,
"caseExact": false,
"mutability": "immutable",
"returned": "request",
"uniqueness": "global"
},

@bzuidgeest
Copy link
Author

I believe the second problem is caused by line 20 SCIMSchemaextensions.cs

{ SCIMConstants.StandardSCIMRepresentationAttributes.Name, schema.Name},
{ SCIMConstants.StandardSCIMRepresentationAttributes.Description, schema.Name}

@simpleidserver
Copy link
Owner

This issue will be fixed in the next release.

@simpleidserver simpleidserver added this to In Progress in 1.0.9 Mar 5, 2020
@simpleidserver simpleidserver self-assigned this Mar 5, 2020
@simpleidserver simpleidserver added the bug Something isn't working label Mar 5, 2020
thabart added a commit that referenced this issue Mar 5, 2020
@bzuidgeest
Copy link
Author

You fixed the first but not the second one in SCIMSchemaextensions or is "{ SCIMConstants.StandardSCIMRepresentationAttributes.Description, schema.Name}" correct? I believe not.
Thank you for all your quick responses.

@simpleidserver
Copy link
Owner

Indeed we didn't pay attention about your second remark.

We will fix it and update the acceptance test to cover all the properties of the schema.

@bzuidgeest
Copy link
Author

Don't worry about it, your responses have been fast and excellent and fixes are applied. I Cannot ask for more in what is after al an freely available project.

@simpleidserver
Copy link
Owner

The error is fixed in the commit : "3a29ea1"

@simpleidserver simpleidserver moved this from In Progress to Done in 1.0.9 Mar 9, 2020
@bzuidgeest
Copy link
Author

There is a new typo in this commit EnterpriseUser is spelled as EntrepriseUser. This is simple typo. I make many myself

thabart added a commit that referenced this issue Mar 10, 2020
@simpleidserver
Copy link
Owner

The typo is fixed in the commit "d1a4222".

@simpleidserver simpleidserver moved this from Done to In Progress in 1.0.9 Mar 13, 2020
@simpleidserver simpleidserver removed this from In Progress in 1.0.9 Mar 13, 2020
@simpleidserver simpleidserver added this to Done in 1.1.0 Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
1.1.0
Done
Development

No branches or pull requests

2 participants