-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo in SCIM naming. #22
Comments
I believe the second problem is caused by line 20 SCIMSchemaextensions.cs { SCIMConstants.StandardSCIMRepresentationAttributes.Name, schema.Name}, |
This issue will be fixed in the next release. |
You fixed the first but not the second one in SCIMSchemaextensions or is "{ SCIMConstants.StandardSCIMRepresentationAttributes.Description, schema.Name}" correct? I believe not. |
Indeed we didn't pay attention about your second remark. We will fix it and update the acceptance test to cover all the properties of the schema. |
Don't worry about it, your responses have been fast and excellent and fixes are applied. I Cannot ask for more in what is after al an freely available project. |
The error is fixed in the commit : "3a29ea1" |
There is a new typo in this commit EnterpriseUser is spelled as EntrepriseUser. This is simple typo. I make many myself |
The typo is fixed in the commit "d1a4222". |
Line 20 in StandardSCIMRepresentationAttributes has a value of "descriptions" I believe this should be "description" without an "s" add the end. Please correct me if I am wrong.
Also The description on the schema (schemas endpoint) takes the name from the schemabuilder and not the provided description. The resourceType endpoint does do this properly.
{
"id": "urn:ietf:params:scim:schemas:extension:nleducation:1.0:eduuser",
"name": "eduUser",
"descriptions": "eduUser",
"attributes": [
{
"name": "eckId",
"type": "string",
"multiValued": false,
"descriptions": "The unique identification of the user for digital content",
"required": true,
"caseExact": false,
"mutability": "immutable",
"returned": "request",
"uniqueness": "global"
},
The text was updated successfully, but these errors were encountered: