SJ-PT-23-02: Fix missing reference count decrease

simplejson · Apr 4, 2023 · 1e495c1 · 1e495c1
1 parent 7c2ccb7
commit 1e495c1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -2,6 +2,8 @@ Version 3.19.0 released 2023-04-XX
 
 * Fix invalid handling of unicode escape sequences in the pure Python
   implementation of the decoder (SJ-PT-23-01)
+* Fix missing reference count decrease if PyOS_string_to_double raises
+  an exception in Python 2.x; was probably unreachable (SJ-PT-23-02)
 
 Version 3.18.4 released 2023-03-14
 

diff --git a/simplejson/_speedups.c b/simplejson/_speedups.c
@@ -1949,8 +1949,10 @@ _match_number_str(PyScannerObject *s, PyObject *pystr, Py_ssize_t start, Py_ssiz
             /* rval = PyFloat_FromDouble(PyOS_ascii_atof(PyString_AS_STRING(numstr))); */
             double d = PyOS_string_to_double(PyString_AS_STRING(numstr),
                                              NULL, NULL);
-            if (d == -1.0 && PyErr_Occurred())
+            if (d == -1.0 && PyErr_Occurred()) {
+                Py_DECREF(numstr);
                 return NULL;
+            }
             rval = PyFloat_FromDouble(d);
         }
     }